Use bool as the return from VADD

Author: mgravell

docs/ReleaseNotes.md

@@ -13,6 +13,7 @@ Current package versions:
 - Add `Condition.SortedSet[Not]ContainsStarting` condition for transactions ([#2638 by ArnoKoll](https://github.com/StackExchange/StackExchange.Redis/pull/2638))
 - Add support for XPENDING Idle time filter ([#2822 by david-brink-talogy](https://github.com/StackExchange/StackExchange.Redis/pull/2822))
 - Improve `double` formatting performance on net8+ ([#2928 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2928))
+- Add vector-set support ([#2939 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2939))
 
 ## 2.8.58
 

src/StackExchange.Redis/Interfaces/IDatabase.cs

@@ -3444,9 +3444,9 @@ IEnumerable<SortedSetEntry> SortedSetScan(
         /// <param name="useCheckAndSet">Optional check-and-set mode for partial threading (CAS parameter).</param>
         /// <param name="attributesJson">Optional JSON attributes for the element (SETATTR parameter).</param>
         /// <param name="flags">The flags to use for this operation.</param>
-        /// <returns>The number of elements added to the vectorset.</returns>
+        /// <returns><see langword="true"/> if the element was added; <see langword="false"/> if it already existed.</returns>
         /// <remarks><seealso href="https://redis.io/commands/vadd"/></remarks>
-        long VectorSetAdd(
+        bool VectorSetAdd(
             RedisKey key,
             RedisValue element,
             ReadOnlyMemory<float> values,

src/StackExchange.Redis/Interfaces/IDatabaseAsync.cs

@@ -847,7 +847,7 @@ IAsyncEnumerable<SortedSetEntry> SortedSetScanAsync(
         // Vector Set operations
 
         /// <inheritdoc cref="IDatabase.VectorSetAdd(RedisKey, RedisValue, ReadOnlyMemory{float}, int?, VectorQuantizationType, int?, int?, bool, string?, CommandFlags)"/>
-        Task<long> VectorSetAddAsync(
+        Task<bool> VectorSetAddAsync(
             RedisKey key,
             RedisValue element,
             ReadOnlyMemory<float> values,

src/StackExchange.Redis/KeyspaceIsolation/KeyPrefixed.cs

@@ -815,7 +815,7 @@ public void WaitAll(params Task[] tasks) =>
             Inner.WaitAll(tasks);
 
         // Vector Set operations - async methods
-        public Task<long> VectorSetAddAsync(
+        public Task<bool> VectorSetAddAsync(
             RedisKey key,
             RedisValue element,
             ReadOnlyMemory<float> values,

src/StackExchange.Redis/KeyspaceIsolation/KeyPrefixedDatabase.cs

@@ -806,7 +806,7 @@ public long KeyTouch(RedisKey[] keys, CommandFlags flags = CommandFlags.None) =>
             Inner.KeyTouch(ToInner(keys), flags);
 
         // Vector Set operations
-        public long VectorSetAdd(
+        public bool VectorSetAdd(
             RedisKey key,
             RedisValue element,
             ReadOnlyMemory<float> values,

src/StackExchange.Redis/PublicAPI/PublicAPI.Unshipped.txt

@@ -24,7 +24,7 @@ StackExchange.Redis.VectorSimilarityResult.Member.get -> StackExchange.Redis.Red
 StackExchange.Redis.VectorSimilarityResult.Score.get -> double
 StackExchange.Redis.VectorSimilarityResult.VectorSimilarityResult() -> void
 StackExchange.Redis.VectorSimilarityResult.VectorSimilarityResult(StackExchange.Redis.RedisValue member, double score = NaN, string? attributesJson = null) -> void
-StackExchange.Redis.IDatabase.VectorSetAdd(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue element, System.ReadOnlyMemory<float> values, int? reducedDimensions = null, StackExchange.Redis.VectorQuantizationType quantizationType = StackExchange.Redis.VectorQuantizationType.Int8, int? buildExplorationFactor = null, int? maxConnections = null, bool useCheckAndSet = false, string? attributesJson = null, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> long
+StackExchange.Redis.IDatabase.VectorSetAdd(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue element, System.ReadOnlyMemory<float> values, int? reducedDimensions = null, StackExchange.Redis.VectorQuantizationType quantizationType = StackExchange.Redis.VectorQuantizationType.Int8, int? buildExplorationFactor = null, int? maxConnections = null, bool useCheckAndSet = false, string? attributesJson = null, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> bool
 StackExchange.Redis.IDatabase.VectorSetContains(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue member, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> bool
 StackExchange.Redis.IDatabase.VectorSetDimension(StackExchange.Redis.RedisKey key, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> int
 StackExchange.Redis.IDatabase.VectorSetGetApproximateVector(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue member, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> StackExchange.Redis.Lease<float>?
@@ -39,7 +39,7 @@ StackExchange.Redis.IDatabase.VectorSetRemove(StackExchange.Redis.RedisKey key,
 StackExchange.Redis.IDatabase.VectorSetSetAttributesJson(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue member, string! jsonAttributes, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> bool
 StackExchange.Redis.IDatabase.VectorSetSimilaritySearchByVector(StackExchange.Redis.RedisKey key, System.ReadOnlyMemory<float> vector, long count = 10, bool withScores = false, bool withAttributes = false, double? epsilon = null, int? searchExplorationFactor = null, string? filterExpression = null, int? maxFilteringEffort = null, bool useExactSearch = false, bool disableThreading = false, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> StackExchange.Redis.Lease<StackExchange.Redis.VectorSimilarityResult>?
 StackExchange.Redis.IDatabase.VectorSetSimilaritySearchByMember(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue member, long count = 10, bool withScores = false, bool withAttributes = false, double? epsilon = null, int? searchExplorationFactor = null, string? filterExpression = null, int? maxFilteringEffort = null, bool useExactSearch = false, bool disableThreading = false, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> StackExchange.Redis.Lease<StackExchange.Redis.VectorSimilarityResult>?
-StackExchange.Redis.IDatabaseAsync.VectorSetAddAsync(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue element, System.ReadOnlyMemory<float> values, int? reducedDimensions = null, StackExchange.Redis.VectorQuantizationType quantizationType = StackExchange.Redis.VectorQuantizationType.Int8, int? buildExplorationFactor = null, int? maxConnections = null, bool useCheckAndSet = false, string? attributesJson = null, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> System.Threading.Tasks.Task<long>!
+StackExchange.Redis.IDatabaseAsync.VectorSetAddAsync(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue element, System.ReadOnlyMemory<float> values, int? reducedDimensions = null, StackExchange.Redis.VectorQuantizationType quantizationType = StackExchange.Redis.VectorQuantizationType.Int8, int? buildExplorationFactor = null, int? maxConnections = null, bool useCheckAndSet = false, string? attributesJson = null, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> System.Threading.Tasks.Task<bool>!
 StackExchange.Redis.IDatabaseAsync.VectorSetContainsAsync(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue member, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> System.Threading.Tasks.Task<bool>!
 StackExchange.Redis.IDatabaseAsync.VectorSetDimensionAsync(StackExchange.Redis.RedisKey key, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> System.Threading.Tasks.Task<int>!
 StackExchange.Redis.IDatabaseAsync.VectorSetGetApproximateVectorAsync(StackExchange.Redis.RedisKey key, StackExchange.Redis.RedisValue member, StackExchange.Redis.CommandFlags flags = StackExchange.Redis.CommandFlags.None) -> System.Threading.Tasks.Task<StackExchange.Redis.Lease<float>?>!

src/StackExchange.Redis/RedisDatabase.cs

@@ -5723,7 +5723,7 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
         }
 
         // Vector Set operations - stub implementations (to be implemented)
-        public long VectorSetAdd(
+        public bool VectorSetAdd(
             RedisKey key,
             RedisValue element,
             ReadOnlyMemory<float> values,
@@ -5833,7 +5833,7 @@ public bool VectorSetSetAttributesJson(RedisKey key, RedisValue member, string j
         }
 
         // Vector Set async operations
-        public Task<long> VectorSetAddAsync(
+        public Task<bool> VectorSetAddAsync(
             RedisKey key,
             RedisValue element,
             ReadOnlyMemory<float> values,

tests/StackExchange.Redis.Tests/VectorSetIntegrationTests.cs

@@ -22,7 +22,7 @@ public async Task VectorSetAdd_BasicOperation()
         var vector = new float[] { 1.0f, 2.0f, 3.0f, 4.0f };
         var result = await db.VectorSetAddAsync(key, "element1", vector.AsMemory());
 
-        Assert.Equal(1, result);
+        Assert.True(result);
     }
 
     [Fact]
@@ -39,7 +39,7 @@ public async Task VectorSetAdd_WithAttributes()
 
         var result = await db.VectorSetAddAsync(key, "element1", vector.AsMemory(), attributesJson: attributes);
 
-        Assert.Equal(1, result);
+        Assert.True(result);
 
         // Verify attributes were stored
         var retrievedAttributes = await db.VectorSetGetAttributesJsonAsync(key, "element1");