Use up-to-date releases of Redis for CI workflow #2855
Merged
NickCraver merged 3 commits intoStackExchange:mainfrom May 4, 2025
Merged
Use up-to-date releases of Redis for CI workflow #2855NickCraver merged 3 commits intoStackExchange:mainfrom
NickCraver merged 3 commits intoStackExchange:mainfrom
Conversation
set target as 7.4.0 both for ubuntu and windows tests fetch dept check old values path fix start all stack server fix step checkout docker image redis:7.4.2
Collaborator
|
@atakavci I have been checking on our ability to run Redis in Docker from Windows agents and did not realize it had finally happened. This is awesome. I need to find time to get the test suite reliably stable, that's the main thing standing in the way a lot of days, but this looks great. Trying to get a minor release out for a known cluster issue then will get this in. |
NickCraver
reviewed
Mar 8, 2025
Contributor
Author
|
hey @NickCraver , any updates with this one ? please let me know if you have any concern.. |
mgravell
approved these changes
Apr 22, 2025
Collaborator
|
LGTM, but I'm trying to see if I can poke the CI; a CI change with red CI is ... #awkward - but: the CI has been getting flakier lately; needs some love |
Collaborator
|
(CI was refusing to rerun, presumably too old; I pushed an empty commit to see if we can poke it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to update the Redis versions running in the CI, there are two different test setups according to environments, one on Ubuntu and the other on Windows;
Setup for Windows essentially leverages wsl setup on windows and install+run the version of Redis from its own package repository. The rest is similar to existing approach, using the same config files etc..