Fix ARGREP NOCASE logic inversion and support ARINFO FULL#3087
Merged
Conversation
- add IsReversed to simplify reversal logic
uglide
approved these changes
May 22, 2026
- refactors ArrayInfo initialization to be span based, and put the main logic inside ArrayInfo technically this is a break, but: `[Experimental]`
mgravell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARGREP NOCASE(logic inverted)IsReversedto simplify reversal logicARINFO FULLas part of this, the build-time generator has been updated to support enum -> string/span maps, for example:
This has also been retro-fitted to keyspace-notifications.