Skip to content

fix: display long TXT records as one string in preview #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raman1236 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix: display long TXT records as one string in preview #4190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ func (rc *RecordConfig) ToComparableNoTTL() string {
// SoaSerial is not included because it isn't used in comparisons.
case "TXT":
// fmt.Fprintf(os.Stdout, "DEBUG: ToComNoTTL raw txts=%s q=%q\n", rc.target, rc.target)
r := txtutil.EncodeQuoted(rc.target)
r := txtutil.EncodeSingle(rc.target)
// fmt.Fprintf(os.Stdout, "DEBUG: ToComNoTTL cmp txts=%s q=%q\n", r, r)
return r
case "LUA":
Expand Down
7 changes: 7 additions & 0 deletions pkg/txtutil/txtcode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ func EncodeQuoted(t string) string {
return txtEncode(ToChunks(t))
}

// EncodeSingle encodes a string as a single quoted value without splitting
// into 255-octet chunks. This is intended for user-facing display (e.g., diff
// preview) where the chunked representation is confusing.
func EncodeSingle(t string) string {
return txtEncode([]string{t})
}

// State denotes the parser state.
type State int

Expand Down