Skip to content

Commit 6352608

Browse files
committed
Improve webui UX with kv.entry.*
It's confusing to have to scroll down in the web UI to remember to include the entry name, so make it required, and use position to tell the webui order the params should be shown in. Signed-off-by: Jacob Floyd <cognifloyd@gmail.com>
1 parent b66ac5d commit 6352608

File tree

5 files changed

+25
-14
lines changed

5 files changed

+25
-14
lines changed

actions/kv_append_entry_property.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,19 @@ parameters:
1414
key:
1515
required: true
1616
type: string
17+
position: 0
1718
entry:
18-
description: name of the key's entry
19-
required: false
19+
description: name of the key's entry (or fallback entry)
20+
required: true
2021
type: string
21-
default: default
22+
position: 1
2223
property:
2324
description: name of the entry's property to append to (property should have an array value)
2425
required: true
2526
type: string
27+
position: 2
2628
value:
2729
description: the value may be any json-serializable type (string, number, array, object)
2830
required: true
2931
# type: any
32+
position: 3

actions/kv_delete_entry_property.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,14 @@ parameters:
1515
key:
1616
required: true
1717
type: string
18+
position: 0
1819
entry:
19-
description: name of the key's entry
20-
required: false
20+
description: name of the key's entry (or fallback entry)
21+
required: true
2122
type: string
22-
default: default
23+
position: 1
2324
property:
2425
description: name of the entry's property to upsert
2526
required: true
2627
type: string
28+
position: 2

actions/kv_get_entry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
class St2KVPGetEntryAction(St2BaseAction):
1111
# noinspection PyShadowingBuiltins
12-
def run(self, key, fallback, entry):
12+
def run(self, key, entry, fallback):
1313
# get and deserialize object or fail.
1414
_key = self.client.keys.get_by_name(key, decrypt=False)
1515

actions/kv_get_entry.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,15 @@ parameters:
1515
key:
1616
required: true
1717
type: string
18+
position: 0
19+
entry:
20+
description: name of the key's entry
21+
required: true
22+
type: string
23+
position: 1
1824
fallback:
1925
description: name of the key's fallback entry
2026
required: false
2127
type: string
2228
default: default
23-
entry:
24-
description: name of the key's entry
25-
required: true
26-
type: string
29+
position: 2

actions/kv_upsert_entry_property.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,19 @@ parameters:
1313
key:
1414
required: true
1515
type: string
16+
position: 0
1617
entry:
17-
description: name of the key's entry
18-
required: false
18+
description: name of the key's entry (or fallback entry)
19+
required: true
1920
type: string
20-
default: default
21+
position: 1
2122
property:
2223
description: name of the entry's property to upsert
2324
required: true
2425
type: string
26+
position: 2
2527
value:
2628
description: the property value may be any json-serializable type (string, number, array, object)
2729
required: true
2830
# type: any
31+
position: 3

0 commit comments

Comments
 (0)