gevent support seems to be WIP - add pants: no-infer-dep comments

cognifloyd · cognifloyd · commit af58fe974025 · 2023-03-09T16:49:38.000-06:00
diff --git a/st2common/st2common/util/BUILD b/st2common/st2common/util/BUILD
@@ -1 +1,8 @@
 python_sources()
+
+# st2common.utils.concurrency allows using gevent instead of eventlet.
+# This gevent support is WIP.
+# python_requirement(
+#    name="gevent",
+#    requirements=["gevent"],
+# )
diff --git a/st2common/st2common/util/concurrency.py b/st2common/st2common/util/concurrency.py
@@ -26,7 +26,7 @@
     eventlet = None
 
 try:
-    import gevent  # pylint: disable=import-error
+    import gevent  # pylint: disable=import-error # pants: no-infer-dep
     import gevent.pool
 except ImportError:
     gevent = None
diff --git a/st2common/st2common/util/monkey_patch.py b/st2common/st2common/util/monkey_patch.py
@@ -56,6 +56,7 @@ def monkey_patch(patch_thread=None):
     if patch_thread is None:
         patch_thread = not is_use_debugger_flag_provided()
 
+    # TODO: support gevent.patch_all if .concurrency.CONCURRENCY_LIBRARY = "gevent"
     eventlet.monkey_patch(
         os=True, select=True, socket=True, thread=patch_thread, time=True
     )

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ def monkey_patch(patch_thread=None):`
`56`	`56`	`if patch_thread is None:`
`57`	`57`	`patch_thread = not is_use_debugger_flag_provided()`
`58`	`58`
	`59`	`+ # TODO: support gevent.patch_all if .concurrency.CONCURRENCY_LIBRARY = "gevent"`
`59`	`60`	`eventlet.monkey_patch(`
`60`	`61`	`os=True, select=True, socket=True, thread=patch_thread, time=True`
`61`	`62`	`)`