Commit 5de74d0
authored
0.17 phase 5 PR C: defaults_keys, chown_owner_group, macos apps + spec patches (#146)
* refactor(engine): inject params["prev_arg"] for NEEDS_PREV_ARG providers
* feat(defaults): defaults_keys provider for read/write/delete/rename key args
* feat(chown): colon-aware chown_owner_group provider
* feat(macos): macos_applications + macos_bundle_identifiers providers
* feat(specs): patch open, osascript, codesign — replace requires_js with native providers/statics
* chore(specs): bump unsupported-without-runtime baseline to 292; cargo fmt
* chore(specs): refresh chown/codesign/defaults/open/osascript snapshots
* fix: address review findings on macOS completion providers
- macos_apps: parallelize bundle-id mdls lookups via bounded tokio JoinSet
(was up to 500 serial subprocess spawns); split mdfind/mdls spawn errors
into trace (binary missing) vs warn (timeout/crash) via is_binary_missing;
emit one aggregate warn when candidates resolve zero bundle ids; extract
pure app_paths_to_resolve/assemble_bundle_identifiers helpers with tests
- macos_defaults: fix parse_defaults_keys desync on ';' inside quoted values;
extract pure resolve_domain + add DefaultsKeys dispatch tests; promote
defaults-read spawn-failure log from trace to warn
- dscl_principals: correct ChownOwnerGroup doc (fetches one principal set per
dispatch, not both) and ChownToken doc (engine re-ranks via fuzzy::rank)
- providers/mod: add inject_prev_arg positive-path tests
* fix: correct macOS provider docs, deepen defaults parser, add concurrency tests
- macos_defaults: parse_defaults_keys now tracks quote state at every depth
(was depth-1 only), so unbalanced braces/parens inside a nested quoted
value no longer desync depth and drop sibling keys; add nested-value
regression test plus end-to-end DefaultsKeys read->parse->suggestion tests
(incl. -globalDomain rewrite flowing through to the real read)
- dscl_principals + providers/mod: drop the false "nucleo treats ':' as a
fuzzy delimiter" claim from the ChownOwnerGroup docs (nucleo matches ':'
as an ordinary subsequence character), matching the corrected ChownToken doc
- providers/mod: extract PREV_ARG_KEY const shared by inject_prev_arg and the
DefaultsKeys consumer to prevent silent producer/consumer drift
- tests: add end-to-end coverage of the bounded-concurrency mdls fan-out with
a deterministic sentinel-barrier to force out-of-order JoinSet completion
without racing the 1s mdls timeout under parallel-suite load
* test: cover MacosApplications mapping + chown live branch; fix golden_specs doc
- add MacosApplications success-path test pinning text=display-name and
description=full-path (a text/description swap now fails the suite)
- add ChownOwnerGroup live branch-selection test: an owner-only token fetches
only /Users, a colon token fetches only /Groups
- golden_specs: drop the stale "nucleo treats ':' as a delimiter" comment
(nucleo matches ':' as an ordinary subsequence character), matching the
corrected provider docs1 parent f1db898 commit 5de74d0
19 files changed
Lines changed: 2055 additions & 88 deletions
File tree
- crates
- gc-pty/src
- gc-suggest
- src
- providers
- tests
- specs
- __snapshots__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1897 | 1897 | | |
1898 | 1898 | | |
1899 | 1899 | | |
1900 | | - | |
| 1900 | + | |
| 1901 | + | |
| 1902 | + | |
| 1903 | + | |
| 1904 | + | |
| 1905 | + | |
| 1906 | + | |
| 1907 | + | |
1901 | 1908 | | |
1902 | 1909 | | |
1903 | 1910 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
0 commit comments