0.17 phase 4 / PR C — TUI: adaptive layout, scroll, filter#143
Open
StanMarek wants to merge 1 commit into
Open
0.17 phase 4 / PR C — TUI: adaptive layout, scroll, filter#143StanMarek wants to merge 1 commit into
StanMarek wants to merge 1 commit into
Conversation
- 3/2/1 pane layouts at width >= 100 / >= 60 / narrow. - Field list now uses Paragraph scroll offset (PgUp/PgDn/Home/End). - '/' opens a filter that narrows fields by key/help substring. - Preview panel becomes collapsible (toggle 'p') at medium widths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config editadapts: 3-pane at width >=100, 2-pane >=60, 1-pane below.Preview pane collapsible (
p) at medium widths.Paragraph::scrollwith offset state; PgUp/PgDn/Home/End scroll it. Long sections no longer silently clip.
/opens a filter prompt; key + help substring matchedcase-insensitively. Esc clears.
Test plan
cargo test --workspacegreen (all crates; tui crate alone runs 81 tests including 17 new ones).filter_narrows_field_listandscroll_offset_clamped_to_field_countcover the new state.
ratatui::backend::TestBackendat 30, 50,80, 120 cols, plus the filtered + FilterInput prompt variants —
every layout branch in
render()exercised end-to-end.explicitly per CLAUDE.md ("if you can't test the UI, say so
explicitly rather than claiming success"). The 7 render smoke unit
tests replace the no-panic side of the manual smoke; visual
verification still wanted before merge.
Coordination
tui/fields.rstest mod append) and PR B(status.rs / main.rs / README.md / SECURITY.md). My only
fields.rsreference is
all_fields()reads fromApp::new, unchanged.