0.17 phase 4 PR B: status --verbose + README/SECURITY refresh#144
Open
StanMarek wants to merge 2 commits into
Open
0.17 phase 4 PR B: status --verbose + README/SECURITY refresh#144StanMarek wants to merge 2 commits into
StanMarek wants to merge 2 commits into
Conversation
Plain `status` now prints a one-line summary; `--verbose` dumps the full list (preserving the JSON contract for dashboards). Saves users from ~17K aws commands flooding their terminal on every check.
…d policy README dropped the stale 'keystroke required' note (contradicted by the dynamic merge loop). SECURITY.md replaces hard-coded 0.10.x with a release-policy statement; lists shell escape handling, config/spec parsing, and JS runtime sandbox as security-relevant areas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ghost-complete statusnow prints a one-line JS-only summary by default;--verbosedumps the full list. JSON output unchanged (dashboards stay green).gc-pty/src/proxy.rs:265-283, gated bypopup.render_block_ms(default 80ms, range 0-300ms).docs/CONFIGURATION.md.0.10.xtable with a "latest stable minor + in-flight RC" policy statement.<maintainer-email>placeholder left intentionally for the reviewer to fill in (or replace with the noreply alias) before merge — DO NOT merge with the literal placeholder in.Implementation notes
render_status(out, &outcome, verbose)symbol did not exist in the repo; extracted apub(crate) fn render_status_text(out, &outcome, verbose)out ofrun_status_innerso the new tests have a pure render entry point.verbose: boolthreaded throughrun_status_inner→run_status_inner_with_trend→run_status_with_opts_to_writer→run_status_with_opts. JSON branch (run_status_json) intentionally does NOT acceptverbose— the dashboard contract is verbose-by-default.## Known Limitations); the replacement reframes it as a feature with therender_block_msknob. Reading it under "Known Limitations" is mildly awkward, but matches the plan's prescription verbatim and stays in the same section so existing anchor links keep working.aws,cargo,apt, …), not subcommands. The plan's expected ">100 aws lines" was based on a misread of the data shape — actual verbose dump is 180 distinct top-level commands. The unit tests use a synthetic fixture withaws s3/aws ec2to pin the plain-vs-verbose split independent of the real corpus shape.Test plan
cargo test --workspacegreen (one pre-existing flake ingc-suggest::evictionthat passes on isolated rerun — unrelated to this PR's surface).status_plain_does_not_dump_js_commands_listandstatus_verbose_dumps_js_commands_listcover the plain/verbose split;status_json_payload_is_unchanged_by_verbosepins JSON byte-equality across--verbose.cargo clippy --all-targets -- -D warningsclean.cargo fmt --checkclean.statusshort (one-line js summary),status --verboselists 180 top-level commands,diff <(status --json) <(status --verbose --json)is empty.Coordination
PR A (drift battery) and PR C (TUI ergonomics) touch disjoint files. Phase 5 (macos-smart-completions) is also disjoint. Zero expected conflicts in either direction.