Missing inplace=True parameter in RINEX nav columns renaming#181
Missing inplace=True parameter in RINEX nav columns renaming#181FedericoPivotto wants to merge 4 commits intoStanford-NavLab:mainfrom
Conversation
|
I have also adjust RINEX nav name convetion to make it compatible with the other library tools. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 27 27
Lines 3882 3882
=======================================
Hits 3869 3869
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for using the library @FedericoPivotto and these look like great additions. Sorry I've been traveling and it's taken a bit to check the PR. I should be able to approve and build a new version next week. If you get to it before me, please also add your name to the contributors list. |
|
I have disabled poetry parallel installation. |
|
I scheduled some time for myself to take a look at the poetry / dependency issues this weekend. Looks like we may need to update some packages and github workflows to update compatibility before merging these changes in. |
|
I agree with you, thank you. |
RINEX nav columns X, Y, Z and their deviation are not renamed.
The addition of inplace=True parameter fix the issue.