[BugFix] Fix num_short_key_columns mismatch in partial tablet schema

[luohaha]

Why I'm doing:

Fix BE DCHECK crash num_short_keys <= sort_key_idxes.size() in SeekTuple::short_key_encode during column-mode partial update on primary key tables with separate sort keys (e.g. ORDER BY(k3, k2)).

TabletSchema::create copies num_short_key_columns from the source schema (e.g. 2), but sort_key_idxes in the partial schema may be empty when sort key columns are not in the partial column set. _init_from_pb then falls back to using key columns as sort keys (e.g. size=1), creating an inconsistency: num_short_key_columns(2) > sort_key_idxes.size()(1).

What I'm doing:

After constructing the partial tablet schema, ensure num_short_key_columns <= sort_key_idxes.size() to keep them consistent.

Trigger SQL:

CREATE TABLE tab1 (k0 int NOT NULL, k1 int, k2 int, k3 int, k4 int, k5 int, v1 int, v2 int)
PRIMARY KEY(k0) DISTRIBUTED BY HASH(k0) BUCKETS 1 ORDER BY(k3, k2)
PROPERTIES ("replication_num" = "1");

INSERT INTO tab1 VALUES (1,1,1,1,1,1,1,1);
SET partial_update_mode = 'column';
UPDATE tab1 SET k4 = 1;  -- crashes in ASAN build

Fixes https://github.com/StarRocks/StarRocksTest/issues/11136

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This PR needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
• This is a backport PR

Bugfix cherry-pick branch check:

• I have checked the version labels which the PR will be auto-backported to the target branch
  • 4.0
  • 3.5
  • 3.4

[CelerData-Reviewer]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/storage/tablet_schema.cpp	4	4	100.00%	[]

[github-actions]

@Mergifyio backport branch-4.0

[github-actions]

@Mergifyio backport branch-3.5

[mergify]

backport branch-4.0

✅ Backports have been created

Details

• #70602 [BugFix] Fix num_short_key_columns mismatch in partial tablet schema (backport #70586) has been created for branch branch-4.0 but encountered conflicts

Cherry-pick of ea8b566 has failed:

On branch mergify/bp/branch-4.0/pr-70586
Your branch is up to date with 'origin/branch-4.0'.

You are currently cherry-picking commit ea8b566747.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/storage/tablet_schema.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/test/storage/tablet_schema_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[mergify]

backport branch-3.5

✅ Backports have been created

Details

• #70603 [BugFix] Fix num_short_key_columns mismatch in partial tablet schema (backport #70586) has been created for branch branch-3.5 but encountered conflicts

Cherry-pick of ea8b566 has failed:

On branch mergify/bp/branch-3.5/pr-70586
Your branch is up to date with 'origin/branch-3.5'.

You are currently cherry-picking commit ea8b566747.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/storage/tablet_schema.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/test/storage/tablet_schema_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[luohaha]

https://github.com/Mergifyio backport branch-4.1

[luohaha]

https://github.com/Mergifyio backport branch-4.1.0

[mergify]

backport branch-4.1

✅ Backports have been created

Details

• #71274 [BugFix] Fix num_short_key_columns mismatch in partial tablet schema (backport #70586) has been created for branch branch-4.1

[mergify]

backport branch-4.1.0

✅ Backports have been created

Details

• #71275 [BugFix] Fix num_short_key_columns mismatch in partial tablet schema (backport #70586) has been created for branch branch-4.1.0