[BugFix] fix information_schema.tables not escaping special characters in equality predicates by dontknow9179 · Pull Request #71273 · StarRocks/starrocks

dontknow9179 · 2026-04-03T10:28:34Z

Why I'm doing:

When querying information_schema.tables with an equality predicate like:

SELECT * FROM information_schema.tables
WHERE table_schema = 'my_db' AND table_name = 'a_a';

The value a_a was passed directly to PatternMatcher.createMysqlPattern() as a LIKE pattern, where _ is treated as a single-character wildcard. This caused the query to return unrelated tables like aba, a1a, etc., instead of only the exact table a_a.

Similarly, table names containing backslashes (e.g. a\_a) were not handled correctly — the backslash and underscore interacted with LIKE pattern escaping rules in unexpected ways.

Fixes #67447

What I'm doing

Fix information_schema.tables queries with equality predicates (=) on table_name or table_schema incorrectly treating LIKE-special characters (_, %, \) as wildcards instead of literal characters.

Changes

PatternMatcher.convertMysqlPattern: Rewrite the two-pass conversion to a single-pass approach that correctly escapes regex metacharacters (e.g. (, ), +, [, ]) in table/database names, and properly handles a trailing backslash as a literal character.
PatternMatcher.escapeLikeValue: Add a new utility method that escapes a literal string so it can be safely used as a MySQL LIKE pattern for exact matching (prefixing \, %, and _ with a backslash).
TablesSystemTable.evaluate: Call escapeLikeValue() on the value extracted from = predicates before passing it to the Thrift request. This is the primary fix — the SchemaTableEvaluateRule optimizer rule short-circuits simple equality queries on information_schema.tables and evaluates them directly in the FE without going through PlanFragmentBuilder.visitPhysicalSchemaScan.
PlanFragmentBuilder.visitPhysicalSchemaScan: Also call escapeLikeValue() for = predicates on TABLE_NAME/TABLE_SCHEMA/DATABASE_NAME in the SchemaScan path, which is used when SchemaTableEvaluateRule is disabled or when the predicate is not a simple equality.
InformationSchemaDataSource.generateTablesInfoResponse: Remove the fallback OR-logic in matchPattern and use matcher.match() directly, preventing false-positive matches when the pattern matcher rejects a name but the raw string comparison accidentally matches.

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
- This pr needs auto generate documentation
This is a backport pr

Bugfix cherry-pick branch check:

CelerData-Reviewer · 2026-04-03T10:29:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de34f44b20

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: dontknow9179 <clin56322@gmail.com>

github-actions · 2026-04-07T09:40:49Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-04-07T09:41:47Z

[FE Incremental Coverage Report]

✅ pass : 29 / 29 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/common/PatternMatcher.java	17	17	100.00%	[]
🔵	com/starrocks/catalog/system/information/TablesSystemTable.java	2	2	100.00%	[]
🔵	com/starrocks/sql/plan/PlanFragmentBuilder.java	9	9	100.00%	[]
🔵	com/starrocks/service/InformationSchemaDataSource.java	1	1	100.00%	[]

github-actions · 2026-04-07T09:42:07Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-04-08T02:23:25Z

@Mergifyio backport branch-4.0

github-actions · 2026-04-08T02:23:26Z

@Mergifyio backport branch-4.1

github-actions · 2026-04-08T02:23:27Z

@Mergifyio backport branch-3.5

mergify · 2026-04-08T02:23:31Z

backport branch-4.0

✅ Backports have been created

Details

#71402 [BugFix] fix information_schema.tables not escaping special characters in equality predicates (backport #71273) has been created for branch branch-4.0

mergify · 2026-04-08T02:23:32Z

backport branch-4.1

✅ Backports have been created

Details

#71403 [BugFix] fix information_schema.tables not escaping special characters in equality predicates (backport #71273) has been created for branch branch-4.1

mergify · 2026-04-08T02:23:33Z

backport branch-3.5

✅ Backports have been created

Details

#71404 [BugFix] fix information_schema.tables not escaping special characters in equality predicates (backport #71273) has been created for branch branch-3.5 but encountered conflicts

Cherry-pick of 1224bae has failed:

On branch mergify/bp/branch-3.5/pr-71273
Your branch is up to date with 'origin/branch-3.5'.

You are currently cherry-picking commit 1224bae098.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/common/PatternMatcher.java
	modified:   fe/fe-core/src/test/java/com/starrocks/common/PatternMatcherTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/ScanTest.java
	modified:   test/sql/test_information_schema/R/test_tables_like_escape
	modified:   test/sql/test_information_schema/T/test_tables_like_escape

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TablesSystemTable.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/service/InformationSchemaDataSource.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

…s in equality predicates (#71273) Signed-off-by: dontknow9179 <clin56322@gmail.com> (cherry picked from commit 1224bae)

…s in equality predicates (#71273) Signed-off-by: dontknow9179 <clin56322@gmail.com> (cherry picked from commit 1224bae) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/catalog/system/information/TablesSystemTable.java # fe/fe-core/src/main/java/com/starrocks/service/InformationSchemaDataSource.java # fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java

…s in equality predicates (backport #71273) (#71403) Signed-off-by: dontknow9179 <clin56322@gmail.com> Co-authored-by: Alex <32681448+dontknow9179@users.noreply.github.com>

…s in equality predicates (backport #71273) (#71402) Signed-off-by: dontknow9179 <clin56322@gmail.com> Co-authored-by: Alex <32681448+dontknow9179@users.noreply.github.com>

…s in equality predicates (backport #71273) (#71407) ## Why I'm doing: When querying `information_schema.tables` with an equality predicate like: ```sql SELECT * FROM information_schema.tables WHERE table_schema = 'my_db' AND table_name = 'a_a'; ``` The value `a_a` was passed directly to `PatternMatcher.createMysqlPattern()` as a LIKE pattern, where `_` is treated as a single-character wildcard. This caused the query to return unrelated tables like `aba`, `a1a`, etc., instead of only the exact table `a_a`. Similarly, table names containing backslashes (e.g. `a\_a`) were not handled correctly — the backslash and underscore interacted with LIKE pattern escaping rules in unexpected ways. Fixes #67447 ## What I'm doing Fix `information_schema.tables` queries with equality predicates (`=`) on `table_name` or `table_schema` incorrectly treating LIKE-special characters (`_`, `%`, `\`) as wildcards instead of literal characters. ### Changes 1. **`PatternMatcher.convertMysqlPattern`**: Rewrite the two-pass conversion to a single-pass approach that correctly escapes regex metacharacters (e.g. `(`, `)`, `+`, `[`, `]`) in table/database names, and properly handles a trailing backslash as a literal character. 2. **`PatternMatcher.escapeLikeValue`**: Add a new utility method that escapes a literal string so it can be safely used as a MySQL LIKE pattern for exact matching (prefixing `\`, `%`, and `_` with a backslash). 3. **`TablesSystemTable.evaluate`**: Call `escapeLikeValue()` on the value extracted from `=` predicates before passing it to the Thrift request. This is the **primary fix** — the `SchemaTableEvaluateRule` optimizer rule short-circuits simple equality queries on `information_schema.tables` and evaluates them directly in the FE without going through `PlanFragmentBuilder.visitPhysicalSchemaScan`. 4. **`PlanFragmentBuilder.visitPhysicalSchemaScan`**: Also call `escapeLikeValue()` for `=` predicates on `TABLE_NAME`/`TABLE_SCHEMA`/`DATABASE_NAME` in the SchemaScan path, which is used when `SchemaTableEvaluateRule` is disabled or when the predicate is not a simple equality. 5. **`InformationSchemaDataSource.generateTablesInfoResponse`**: Remove the fallback OR-logic in `matchPattern` and use `matcher.match()` directly, preventing false-positive matches when the pattern matcher rejects a name but the raw string comparison accidentally matches. Signed-off-by: dontknow9179 <clin56322@gmail.com>

…s in equality predicates (backport #71273) (backport #71407) (#72708) Signed-off-by: dontknow9179 <clin56322@gmail.com> Co-authored-by: Alex <32681448+dontknow9179@users.noreply.github.com>

dontknow9179 requested a review from a team as a code owner April 3, 2026 10:28

github-actions Bot added 4.1 3.5 4.0 labels Apr 3, 2026

mergify Bot assigned dontknow9179 Apr 3, 2026

chatgpt-codex-connector Bot reviewed Apr 3, 2026

View reviewed changes

Comment thread fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java Outdated

Wenjun7J approved these changes Apr 7, 2026

View reviewed changes

dontknow9179 added 3 commits April 7, 2026 16:36

fix information_schema.tables name escape

5cf4919

Signed-off-by: dontknow9179 <clin56322@gmail.com>

restrict escapeLike tables

04fd0fd

Signed-off-by: dontknow9179 <clin56322@gmail.com>

fix java ut

aa65d6f

Signed-off-by: dontknow9179 <clin56322@gmail.com>

dontknow9179 force-pushed the fix-information-schema-table-name-escape branch from 1422338 to aa65d6f Compare April 7, 2026 08:36

dirtysalt approved these changes Apr 7, 2026

View reviewed changes

dirtysalt enabled auto-merge (squash) April 7, 2026 10:19

gengjun-git approved these changes Apr 8, 2026

View reviewed changes

dirtysalt merged commit 1224bae into StarRocks:main Apr 8, 2026
54 of 55 checks passed

github-actions Bot removed 4.0 4.1 labels Apr 8, 2026

github-actions Bot removed the 3.5 label Apr 8, 2026

mergify Bot pushed a commit that referenced this pull request Apr 8, 2026

[BugFix] fix information_schema.tables not escaping special character…

7b9decb

…s in equality predicates (#71273) Signed-off-by: dontknow9179 <clin56322@gmail.com> (cherry picked from commit 1224bae)

mergify Bot mentioned this pull request Apr 8, 2026

[BugFix] fix information_schema.tables not escaping special characters in equality predicates (backport #71273) #71402

Merged

24 tasks

mergify Bot pushed a commit that referenced this pull request Apr 8, 2026

[BugFix] fix information_schema.tables not escaping special character…

10c8a9c

…s in equality predicates (#71273) Signed-off-by: dontknow9179 <clin56322@gmail.com> (cherry picked from commit 1224bae)

mergify Bot mentioned this pull request Apr 8, 2026

[BugFix] fix information_schema.tables not escaping special characters in equality predicates (backport #71273) #71403

Merged

24 tasks

mergify Bot mentioned this pull request Apr 8, 2026

[BugFix] fix information_schema.tables not escaping special characters in equality predicates (backport #71273) #71404

Closed

24 tasks

github-actions Bot added 4.1-merged 4.0-merged labels Apr 8, 2026

github-actions Bot added the 3.5-merged label Apr 8, 2026

xiangguangyxg mentioned this pull request May 8, 2026

两问题：1. jdbc catalog 查表不能 * ，2. 迁移工具报错 #72983

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BugFix] fix information_schema.tables not escaping special characters in equality predicates#71273

[BugFix] fix information_schema.tables not escaping special characters in equality predicates#71273
dirtysalt merged 3 commits into
StarRocks:mainfrom
dontknow9179:fix-information-schema-table-name-escape

dontknow9179 commented Apr 3, 2026

Uh oh!

CelerData-Reviewer commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

mergify Bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dontknow9179 commented Apr 3, 2026

Why I'm doing:

What I'm doing

Changes

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

CelerData-Reviewer commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions Bot commented Apr 7, 2026

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions Bot commented Apr 7, 2026

[FE Incremental Coverage Report]

file detail

Uh oh!

github-actions Bot commented Apr 7, 2026

[BE Incremental Coverage Report]

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

mergify Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mergify Bot commented Apr 8, 2026 •

edited

Loading

mergify Bot commented Apr 8, 2026 •

edited

Loading

mergify Bot commented Apr 8, 2026 •

edited

Loading