[BugFix] Fix num_short_key_columns mismatch in partial tablet schema (backport #70586)#71274
Merged
Merged
Conversation
22 tasks
luohaha
previously approved these changes
Apr 3, 2026
luohaha
previously approved these changes
Apr 3, 2026
The Calendar class was used without being imported after backport #71046.
1d35557 to
b4234d0
Compare
luohaha
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Fix BE DCHECK crash
num_short_keys <= sort_key_idxes.size()inSeekTuple::short_key_encodeduring column-mode partial update on primary key tables with separate sort keys (e.g.ORDER BY(k3, k2)).TabletSchema::createcopiesnum_short_key_columnsfrom the source schema (e.g. 2), butsort_key_idxesin the partial schema may be empty when sort key columns are not in the partial column set._init_from_pbthen falls back to using key columns as sort keys (e.g. size=1), creating an inconsistency:num_short_key_columns(2) > sort_key_idxes.size()(1).What I'm doing:
After constructing the partial tablet schema, ensure
num_short_key_columns <= sort_key_idxes.size()to keep them consistent.Trigger SQL:
Fixes https://github.com/StarRocks/StarRocksTest/issues/11136
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request [BugFix] Fix num_short_key_columns mismatch in partial tablet schema #70586 done by Mergify.