[BugFix] insert files credential redaction 3.5 (backport #71245)#71864
Merged
kevincai merged 1 commit intoApr 23, 2026
Merged
Conversation
github-actions
Bot
added
the
documentation
srihithg
force-pushed
the
backport-insert-files-credential-redaction-3.5
branch
from
64f59d4 to
a43893a
Compare
github-actions
Bot
removed
the
documentation
srihithg
force-pushed
the
backport-insert-files-credential-redaction-3.5
branch
from
a43893a to
9bd287d
Compare
srihithg
changed the title
kevincai
requested changes
Apr 21, 2026
srihithg
force-pushed
the
backport-insert-files-credential-redaction-3.5
branch
from
1cf7703 to
ea14c41
Compare
Backport credential redaction for INSERT INTO FILES and related flows to branch-3.5. Compared with the upstream PR on main (StarRocks#71245), this backport: - Preserves the full set of credential regex patterns, including the user-authentication clauses (IDENTIFIED BY / IDENTIFIED WITH / SET PASSWORD) that were introduced by StarRocks#70360 and are also present on branch-3.5. - Adapts SqlCredentialRedactor to the re2j regex engine used on this branch (no backreferences), so the single-/double-quoted KEY = 'value' matching is expressed as two alternatives rather than a backref. - Applies redaction to the same StmtExecutor call sites as branch-4.1 (planner-error log, explain exec-plan failure log, retry loop, LargeInPredicate retry, registerQuery / QueryInfo for both the normal and load paths, DDL QueryStateException + delete-handler + generic-throwable logs, DML fail log, crash-cancel SQL log, insert throwable log) via a new getRedactedOriginStmtInString() helper. Tests: - SqlCredentialRedactorTest mirrors the upstream PR scenarios, including the user-auth clauses. - StmtExecutorTest ports the two redaction-focused scenarios (testGetRedactedOriginStmtInStringScenarios, testBuildTopLevelProfileSqlStatementScenarios). The remaining StatementPlanner / Coordinator / profile-digest tests from StarRocks#71245 depend on APIs (WarehouseManager.getWarehouseComputeResourceName, Config.enable_sql_desensitize_in_log, FormatOptions#setEnableDigest) that don't exist on branch-3.5 and are intentionally skipped. - AuditEncryptionCheckerTest is identical to the upstream PR. Signed-off-by: Srihith Garlapati <srihith.garlapati@gmail.com> Made-with: Cursor
srihithg
force-pushed
the
backport-insert-files-credential-redaction-3.5
branch
from
ea14c41 to
297117b
Compare
kevincai
approved these changes
Apr 23, 2026
Contributor
|
@mergify backport branch-3.5-cc |
Contributor
✅ Backports have been createdDetails
|
24 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
manual backport of #71245
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: