Merge pull request #24 from StarryInternet/better-centralmanager-errors

Don't wrap connection errors in its own case in CentralManagerError, to make it easier to query or case-match normal core bluetooth errors

Author: klundberg

Sources/CombineCoreBluetooth/CentralManager/Interface+CentralManager.swift

@@ -90,8 +90,8 @@ public struct CentralManager {
           .setFailureType(to: Error.self),
         didFailToConnectPeripheral
           .filter { p, _ in p == peripheral }
-          .tryMap { p, error in
-            throw CentralManagerError.failedToConnect(error as NSError?)
+          .tryMap { _, error in
+            throw error ?? CentralManagerError.unknownConnectionFailure
           }
       )
       .prefix(1)

Sources/CombineCoreBluetooth/Models/CentralManagerError.swift

@@ -1,36 +1,15 @@
 import Foundation
 
 public enum CentralManagerError: Error, Equatable {
-  /// Thrown if there's a failure during connection to a peripheral
-  case failedToConnect(NSError?)
+  /// Thrown if there's a failure during connection to a peripheral, but there's no error information
+  case unknownConnectionFailure
 }
 
 extension CentralManagerError: LocalizedError {
   public var errorDescription: String? {
     switch self {
-    case let .failedToConnect(error):
-      return error?.localizedDescription
-    }
-  }
-
-  public var failureReason: String? {
-    switch self {
-    case let .failedToConnect(error):
-      return error?.localizedFailureReason
-    }
-  }
-
-  public var recoverySuggestion: String? {
-    switch self {
-    case let .failedToConnect(error):
-      return error?.localizedRecoverySuggestion
-    }
-  }
-
-  public var helpAnchor: String? {
-    switch self {
-    case let .failedToConnect(error):
-      return error?.helpAnchor
+    case .unknownConnectionFailure:
+      return "Unknown failure connecting to the peripheral."
     }
   }
 }