[pull] master from marmelab:master#42
Merged
pull[bot] merged 9 commits intoStars1233:masterfrom Jun 25, 2025
Merged
Conversation
[chore] Avoid vercel deployment for `gh-pages` branch
Fix `<DataTable>` does not allow to put a button in the column's header
[Storybook] Migrate stories to use DataTable
|
Review these changes at https://app.gitnotebooks.com/Stars1233/react-admin/pull/42 |
Reviewer's GuideThis PR refactors most storybook examples to adopt the new DataTable API in place of the deprecated Datagrid component (using DataTable, DataTable.Col/NumberCol, and updated imports), simplifies the DataTableHeadCell component by removing an unnecessary TableSortLabel wrapper on unsortable columns, and introduces a new HeaderButton story in DataTable.stories.tsx. Class diagram for DataTable and Datagrid refactorclassDiagram
class Datagrid {
<<deprecated>>
}
class DataTable {
+Col
+NumberCol
}
Datagrid <|-- DataTable : replaced by
DataTable o-- DataTable.Col
DataTable o-- DataTable.NumberCol
Class diagram for DataTableHeadCell simplificationclassDiagram
class DataTableHeadCell {
- label
- source
- resource
+ renderSortableHeader()
+ renderUnsortableHeader() // now renders FieldTitle directly
}
class TableSortLabel
class FieldTitle
DataTableHeadCell ..> TableSortLabel : uses (sortable)
DataTableHeadCell ..> FieldTitle : uses (always)
Class diagram for new DataTable HeaderButton storyclassDiagram
class DataTable {
+Col
}
class CreateButton
class EditButton
DataTable o-- DataTable.Col
DataTable.Col o-- CreateButton : header (label)
DataTable.Col o-- EditButton : cell content
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Migrate all storybook examples to use the new DataTable component instead of the deprecated Datagrid, update imports and column definitions accordingly, simplify head cell rendering, and add a custom header button story for DataTable.
Enhancements: