Skip to content

Add Lambert W x F distributions to XGBoostLSS#65

Open
gmgeorg wants to merge 30 commits into
StatMixedML:masterfrom
gmgeorg:lambertw
Open

Add Lambert W x F distributions to XGBoostLSS#65
gmgeorg wants to merge 30 commits into
StatMixedML:masterfrom
gmgeorg:lambertw

Conversation

@gmgeorg

@gmgeorg gmgeorg commented Nov 30, 2023

Copy link
Copy Markdown

Adds skewed and tail Lambert W x F distributions as an option to XGBoostLSS.

In particular, adds Lambert W x {Normal, Weibull, Gamma, Exponential, LogNormal} distributions. Adds examples to notebooks and adds its own California Housing example notebook.

image

@StatMixedML

Copy link
Copy Markdown
Owner

@gmgeorg Thanks for creating the PR.

I assume you further refine the notebooks and the .py files? Since, e.g., the Gaussian example still has some explanations for modelling the gaussian distribution whereas it should explain the Lambert W x F distributions. Also, result wise, the gaussian example notebook does not look good.

@gmgeorg

gmgeorg commented Dec 6, 2023

Copy link
Copy Markdown
Author

@StatMixedML yes will clean up. However, I wanted to send this out first as a general "it works" proof of concept PR. If this looks good to you high level with the current changes, I will continue and
a) clean up .py files
b) update notebooks accordingly
c) fix / add unit tests based on the changes made (in particular dist_select() and changing the 1:1 map between filenames and distribution names to allow for more than 1 distribution class per file)

Let me know if I should revisit/re-implement differently any proposed changes; if not, will go ahead and clean up rest of PR for a e2e review.

@gmgeorg

gmgeorg commented Dec 25, 2023

Copy link
Copy Markdown
Author

@StatMixedML updated PR with changes addressing earlier points. PTAL

@fkiraly

fkiraly commented Jan 26, 2024

Copy link
Copy Markdown
Collaborator

@gmgeorg, would you be interested adding some distributions to skpro?

See proposed integration issue here: sktime/skpro#184

Integration with skpro would pull all the way through to sktime.

@gmgeorg

gmgeorg commented Jan 28, 2024

Copy link
Copy Markdown
Author

@fkiraly Great idea! Will take a look and add an issue there.

@gmgeorg

gmgeorg commented May 8, 2025

Copy link
Copy Markdown
Author

@StatMixedML What's the status here? I'd like to move this along as impelmentation and tests conform to rest of XGB lss. Anything else you want to have added?

@StatMixedML

Copy link
Copy Markdown
Owner

@claude please review this PR

@claude

claude Bot commented Jun 1, 2026

Copy link
Copy Markdown

Claude encountered an error after 53s —— View job


PR Review: Add Lambert W x F distributions to XGBoostLSS

Reviewing PR...

Tasks:

  • Gather context and understand the request
  • Read CLAUDE.md for repo guidelines
  • Review core distribution files
  • Review distribution utils changes
  • Review model.py changes
  • Review test changes
  • Review pyproject.toml / dependency changes
  • Post comprehensive review feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants