fix: remove redundant AuthenticationScheme type param

Author: DrewImm

examples/complete-example/auth/session-auth.ts

@@ -30,7 +30,6 @@ const storedAuthCodes = new Map<
  */
 class OAuth2Scheme extends SessionAuthenticationScheme {
 	public readonly schemeName = 'OAuth2';
-	public readonly type = 'oauth2' as const;
 
 	constructor() {
 		super({ sessionDriver: new InMemorySessionDriver() });

src/authentication/authentication-scheme.ts

@@ -32,15 +32,6 @@ export abstract class AuthenticationScheme {
 	 */
 	public abstract readonly schemeName: string;
 
-	/**
-	 * The type of security scheme as defined by OpenAPI
-	 */
-	public abstract readonly type:
-		| 'http'
-		| 'apiKey'
-		| 'oauth2'
-		| 'openIdConnect';
-
 	/**
 	 * Generate the OpenAPI security scheme object
 	 * This will be added to components.securitySchemes in the OpenAPI spec

src/authentication/schemes/bearer-authentication-scheme.ts

@@ -49,7 +49,6 @@ export interface BearerAuthenticationSchemeOptions extends AuthenticationSchemeO
  * Automatically generates OpenAPI security scheme documentation
  */
 export class BearerAuthenticationScheme extends InlineAuthenticationScheme {
-	public readonly type = 'http' as const;
 	public readonly schemeName: string;
 
 	protected readonly bearerFormat: string;

test/spec/authentication/authentication-scheme.spec.ts

@@ -21,7 +21,6 @@ type AnyResponse = any;
  */
 class TestInlineScheme extends InlineAuthenticationScheme {
 	readonly schemeName = 'TestInline';
-	readonly type = 'http' as const;
 	private throwError = false;
 
 	public setThrowError(shouldThrow: boolean): void {
@@ -55,7 +54,6 @@ describe('AuthenticationScheme (Base Class)', () => {
 		it('should have required abstract properties', () => {
 			class TestScheme extends AuthenticationScheme {
 				readonly schemeName = 'TestScheme';
-				readonly type = 'http' as const;
 
 				getSecurityScheme() {
 					return { type: 'http' as const, scheme: 'test' };
@@ -77,7 +75,6 @@ describe('AuthenticationScheme (Base Class)', () => {
 
 			const scheme = new TestScheme();
 			expect(scheme.schemeName).toBe('TestScheme');
-			expect(scheme.type).toBe('http');
 		});
 
 		it('should have getSecurityRequirement method', () => {
@@ -96,7 +93,7 @@ describe('AuthenticationScheme (Base Class)', () => {
 				checkToken: async () => true,
 			});
 
-			expect(scheme.type).toBe('http');
+			expect(scheme.getSecurityScheme().type).toBe('http');
 		});
 	});
 

test/spec/authentication/bearer-scheme.spec.ts

@@ -15,7 +15,7 @@ describe('BearerAuthenticationScheme', () => {
 			});
 
 			expect(scheme.schemeName).toBe('BearerAuth');
-			expect(scheme.type).toBe('http');
+			expect(scheme.getSecurityScheme().type).toBe('http');
 		});
 
 		it('should use custom scheme name if provided', () => {

test/spec/authentication/session-scheme.spec.ts

@@ -26,7 +26,6 @@ abstract class TestAuthFlowImport extends BaseApiEndpoint {}
  */
 class TestSessionScheme extends SessionAuthenticationScheme {
 	public readonly schemeName = 'TestSession';
-	public readonly type = 'apiKey' as const;
 
 	public constructor(options: { sessionDriver?: SessionDriver } = {}) {
 		super({
@@ -95,7 +94,7 @@ describe('SessionAuthenticationScheme', () => {
 			const scheme = new TestSessionScheme();
 
 			expect(scheme.schemeName).toBe('TestSession');
-			expect(scheme.type).toBe('apiKey');
+			expect(scheme.getSecurityScheme().type).toBe('apiKey');
 		});
 
 		it('should initialize with session driver', () => {
@@ -250,7 +249,6 @@ describe('SessionAuthenticationScheme', () => {
 		it('should use scheme name in requirement', () => {
 			class CustomSessionScheme extends SessionAuthenticationScheme {
 				public readonly schemeName = 'CustomSession';
-				public readonly type = 'apiKey' as const;
 
 				public constructor(
 					options: { sessionDriver?: SessionDriver } = {}
@@ -528,7 +526,6 @@ describe('SessionAuthenticationScheme', () => {
 
 			class TestSchemeWithSteps extends SessionAuthenticationScheme {
 				public readonly schemeName = 'TestScheme';
-				public readonly type = 'oauth2' as const;
 
 				public constructor(
 					options: { sessionDriver?: SessionDriver } = {}
@@ -603,7 +600,6 @@ describe('SessionAuthenticationScheme', () => {
 
 			class TestSchemeWithRoutes extends SessionAuthenticationScheme {
 				public readonly schemeName = 'TestScheme';
-				public readonly type = 'oauth2' as const;
 
 				public constructor(
 					options: { sessionDriver?: SessionDriver } = {}
@@ -653,7 +649,6 @@ describe('SessionAuthenticationScheme', () => {
 		it('should return auth endpoints from the auth flow', () => {
 			class SimpleSessionScheme extends SessionAuthenticationScheme {
 				public readonly schemeName = 'SimpleSession';
-				public readonly type = 'apiKey' as const;
 
 				public constructor(
 					options: { sessionDriver?: SessionDriver } = {}
@@ -704,7 +699,6 @@ describe('SessionAuthenticationScheme', () => {
 		it('should return auth step classes', () => {
 			class MultiStepScheme extends SessionAuthenticationScheme {
 				public readonly schemeName = 'MultiStep';
-				public readonly type = 'oauth2' as const;
 
 				public constructor(
 					options: { sessionDriver?: SessionDriver } = {}
@@ -773,7 +767,6 @@ describe('SessionAuthenticationScheme', () => {
 		it('should return empty array for empty auth flow', () => {
 			class EmptySessionScheme extends SessionAuthenticationScheme {
 				public readonly schemeName = 'EmptySession';
-				public readonly type = 'apiKey' as const;
 
 				public constructor(
 					options: { sessionDriver?: SessionDriver } = {}
@@ -808,7 +801,6 @@ describe('SessionAuthenticationScheme', () => {
 		it('should return endpoints from auth flow', async () => {
 			class MatchingScheme extends SessionAuthenticationScheme {
 				public readonly schemeName = 'Matching';
-				public readonly type = 'apiKey' as const;
 
 				public constructor(
 					options: { sessionDriver?: SessionDriver } = {}