Skip to content

Commit 9ed8cdd

Browse files
authored
fix: mem leak in write when io exception occurs (alibaba#165)
1 parent 7c83b38 commit 9ed8cdd

2 files changed

Lines changed: 0 additions & 2 deletions

File tree

src/paimon/core/mergetree/compact/merge_tree_compact_rewriter.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ Result<CompactResult> MergeTreeCompactRewriter::RewriteCompaction(
190190
auto rolling_writer = CreateRollingRowWriter(output_level);
191191

192192
ScopeGuard write_guard([&]() -> void {
193-
(void)rolling_writer->Close();
194193
rolling_writer->Abort();
195194
for (const auto& reader : reader_holders) {
196195
reader->Close();

src/paimon/core/mergetree/merge_tree_writer.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ Status MergeTreeWriter::Flush() {
146146
/*projection_thread_num=*/1, pool_);
147147
auto rolling_writer = CreateRollingRowWriter();
148148
ScopeGuard write_guard([&]() -> void {
149-
(void)rolling_writer->Close();
150149
rolling_writer->Abort();
151150
async_key_value_producer_consumer->Close();
152151
});

0 commit comments

Comments
 (0)