You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(test): let the fetch-failure inte test expect a converted missing file
TestWriteNullOnFetchFailureKeepsMissingFileFailing still asserted that a
missing descriptor file fails the write when only
'blob-write-null-on-fetch-failure' is enabled. That is the behavior the
previous commit deliberately removed: the FileSystem::Exists check that tells
a missing file apart runs only when 'blob-write-null-on-missing-file' needs
the classification, so with just the fetch-failure option a missing file is
an ordinary open failure and is converted to a NULL element. Only the
comment and the expected message were updated, so the test failed on CI in
every build job.
Rename it to TestWriteNullOnFetchFailureCoversMissingFile and assert the
conversion the way the neighbouring write-null tests do: the write and commit
succeed, both files keep the full row count, and the read merges them back
into a row whose blob is NULL.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
0 commit comments