Skip to content

Commit ca51b80

Browse files
authored
chore: Miscellaneous minor improvements (alibaba#63)
1 parent 4f519ce commit ca51b80

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

include/paimon/read_context.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,9 @@ class PAIMON_EXPORT ReadContextBuilder {
137137

138138
~ReadContextBuilder();
139139

140+
ReadContextBuilder(ReadContextBuilder&&) noexcept;
141+
ReadContextBuilder& operator=(ReadContextBuilder&&) noexcept;
142+
140143
/// Set the schema fields to read from the table.
141144
///
142145
/// If not set, all fields from the table schema will be read. This is useful for

src/paimon/core/operation/read_context.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,9 @@ ReadContextBuilder::ReadContextBuilder(const std::string& path)
105105

106106
ReadContextBuilder::~ReadContextBuilder() = default;
107107

108+
ReadContextBuilder::ReadContextBuilder(ReadContextBuilder&&) noexcept = default;
109+
ReadContextBuilder& ReadContextBuilder::operator=(ReadContextBuilder&&) noexcept = default;
110+
108111
ReadContextBuilder& ReadContextBuilder::AddOption(const std::string& key,
109112
const std::string& value) {
110113
impl_->options_[key] = value;

src/paimon/format/avro/avro_input_stream_impl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ void AvroInputStreamImpl::seek(int64_t position) {
9999
}
100100

101101
bool AvroInputStreamImpl::fill() {
102-
if (static_cast<uint64_t>(total_read_len_) > total_length_) {
102+
if (static_cast<uint64_t>(total_read_len_) >= total_length_) {
103103
// eof
104104
return false;
105105
}

0 commit comments

Comments
 (0)