fix: Fix various UX issues and improve error reporting

Author: shdwmtr

src/components/checkbox.cc

@@ -39,7 +39,7 @@
 
 using namespace ImGui;
 
-const CheckBoxState* RenderCheckBox(bool checked, const char* description, const char* tooltipText, bool disabled, bool endChild)
+const CheckBoxState* RenderCheckBox(bool checked, std::string description, std::string tooltipText, bool disabled, bool endChild)
 {
     static std::unordered_map<std::string, CheckBoxState> checkBoxStates;
     auto& state = checkBoxStates.try_emplace(description, checked).first->second;
@@ -66,15 +66,15 @@ const CheckBoxState* RenderCheckBox(bool checked, const char* description, const
         EndChild();
         SameLine(0, ScaleX(20));
         SetCursorPosY(GetCursorPosY() + ScaleY(3));
-        Text(description);
+        Text(description.c_str());
     } else {
         std::string checkBoxMessage = " " + std::string(description);
 
         Checkbox(checkBoxMessage.c_str(), &state.isChecked);
         EndDisabled();
     }
 
-    if (tooltipText) {
+    if (!tooltipText.empty()) {
         float autoUpdateColor = EaseInOutFloat(description, 0.f, 1.f, state.isHovered, 0.3f);
 
         if (autoUpdateColor) {
@@ -85,7 +85,7 @@ const CheckBoxState* RenderCheckBox(bool checked, const char* description, const
             PushStyleVar(ImGuiStyleVar_Alpha, autoUpdateColor);
             PushStyleColor(ImGuiCol_PopupBg, ImVec4(0.098f, 0.102f, 0.11f, 1.0f));
 
-            SetTooltip(tooltipText);
+            SetTooltip(tooltipText.c_str());
 
             PopStyleVar(3);
             PopStyleColor();

src/include/components.h

@@ -46,6 +46,7 @@
 #include <util.h>
 #include <imgui_markdown.h>
 #include <mini/ini.h>
+#include <format>
 
 using namespace ImGui;
 
@@ -113,23 +114,38 @@ static void UpdateSelectedRelease(const std::string& tag)
 
 const bool FetchVersionInfo()
 {
+    constexpr int MAX_PAGES = 50; // Safety limit (5000 releases max)
+
     // fetch all pages of releases from GitHub (per_page=100)
     releasesList = nlohmann::json::array();
-    int page = 1;
-    for (;;) {
+
+    for (int page = 1; page <= MAX_PAGES; ++page) {
         const auto url = std::format("https://api.github.com/repos/SteamClientHomebrew/Millennium/releases?per_page=100&page={}", page);
-        const auto response = Http::Get(url.c_str(), false);
+        const auto response = Http::GetEx(url.c_str());
+
+        if (response.isNetworkError()) {
+            if (page == 1) {
+                ShowMessageBox("Whoops!", "Failed to connect to the GitHub API! Make sure you have a valid internet connection.", Error);
+                return false;
+            }
+            break;
+        }
+
+        if (response.isRateLimited()) {
+            ShowMessageBox("Whoops!", "GitHub API rate limit exceeded. Please wait a few minutes and try again.", Error);
+            return false;
+        }
 
-        if (response.empty()) {
+        if (!response.ok()) {
             if (page == 1) {
-                ShowMessageBox("Whoops!", "Failed to fetch version information from the GitHub API! Make sure you have a valid internet connection.", Error);
+                ShowMessageBox("Whoops!", std::format("Failed to fetch version information (HTTP {}). Please try again later.", response.statusCode), Error);
                 return false;
             }
             break;
         }
 
         try {
-            auto pageJson = nlohmann::json::parse(response);
+            auto pageJson = nlohmann::json::parse(response.body);
             if (!pageJson.is_array() || pageJson.empty())
                 break;
 
@@ -138,11 +154,9 @@ const bool FetchVersionInfo()
                 releasesList.push_back(r);
         } catch (const nlohmann::json::exception& e) {
             std::cerr << "JSON parse error: " << e.what() << std::endl;
-            ShowMessageBox("Whoops!", "Failed to parse version information from the GitHub API! Please wait a moment and try again, you're likely rate limited.", Error);
+            ShowMessageBox("Whoops!", "Failed to parse version information from the GitHub API!", Error);
             return false;
         }
-
-        page += 1;
     }
 
     // choose default selectedRelease: prefer latest non-prerelease, fall back to first release
@@ -202,7 +216,12 @@ const bool FetchVersionInfo()
         }
     }
 
-    return hasFoundReleaseInfo;
+    if (!hasFoundReleaseInfo) {
+        ShowMessageBox("Whoops!", "We failed to find the latest Millennium release!", Error);
+        return false;
+    }
+
+    return true;
 }
 
 const void RenderInstallPrompt(std::shared_ptr<RouterNav> router, float xPos)

src/include/http.h

@@ -211,7 +211,7 @@ const void RenderComponents()
         {
             /** Not currently uninstalling, the user is selecting components to be uninstalled */
             if (!isUninstalling) {
-                state.isSelected = RenderCheckBox(state.isSelected, formattedComponent.c_str(), strPathList.c_str(), false, true)->isChecked;
+                state.isSelected = RenderCheckBox(state.isSelected, formattedComponent, strPathList, false, true)->isChecked;
                 continue;
             }
 
@@ -348,34 +348,66 @@ const void RenderUninstallSelect(std::shared_ptr<RouterNav> router, float xPos)
     RenderBottomNavBar("InstallPrompt", xPos, [router, xPos]
     {
         static bool isButtonHovered = false;
-        float currentColor = EaseInOutFloat("##NextButton", 1.0f, 0.8f, isButtonHovered, 0.3f);
-
-        PushStyleColor(ImGuiCol_Button, ImVec4(currentColor, currentColor, currentColor, 1.0f));
-        PushStyleColor(ImGuiCol_ButtonHovered, ImVec4(currentColor, currentColor, currentColor, 1.0f));
-        PushStyleColor(ImGuiCol_ButtonActive, ImVec4(0.8f, 0.8f, 0.8f, 1.0f));
 
         if (uninstallFinished) {
+            float currentColor = EaseInOutFloat("##NextButton", 1.0f, 0.8f, isButtonHovered, 0.3f);
+
+            PushStyleColor(ImGuiCol_Button, ImVec4(currentColor, currentColor, currentColor, 1.0f));
+            PushStyleColor(ImGuiCol_ButtonHovered, ImVec4(currentColor, currentColor, currentColor, 1.0f));
+            PushStyleColor(ImGuiCol_ButtonActive, ImVec4(0.8f, 0.8f, 0.8f, 1.0f));
+
             if (Button("Exit", ImVec2(xPos + GetContentRegionAvail().x, GetContentRegionAvail().y))) {
                 std::exit(0);
             }
+
+            if (isButtonHovered) {
+                SetMouseCursor(ImGuiMouseCursor_Hand);
+            }
+
+            PopStyleColor(3);
+            isButtonHovered = IsItemHovered() || (IsItemHovered(ImGuiHoveredFlags_AllowWhenBlockedByActiveItem) && IsMouseDown(ImGuiMouseButton_Left));
+        } else if (isUninstalling) {
+            PushStyleColor(ImGuiCol_ChildBg, ImVec4(0.6f, 0.6f, 0.6f, 1.0f));
+            PushStyleVar(ImGuiStyleVar_ChildRounding, ScaleX(10.0f));
+
+            const float childWidth = GetContentRegionAvail().x;
+            const float childHeight = GetContentRegionAvail().y;
+
+            BeginChild("##ButtonIsBusy", { xPos + childWidth, childHeight }, true, ImGuiWindowFlags_NoScrollbar);
+            {
+                const float spinnerSize = ScaleX(12.f);
+                SetCursorPos({ childWidth / 2 - spinnerSize, spinnerSize });
+
+                Spinner<SpinnerTypeT::e_st_ang>("SpinnerAngNoBg", Radius{ spinnerSize }, Thickness{ ScaleX(2) }, Color{ ImColor(0, 0, 0, 255) },
+                                                BgColor{ ImColor(255, 255, 255, 0) }, Speed{ 6 }, Angle{ IM_PI }, Mode{ 0 });
+            }
+            EndChild();
+            PopStyleColor();
+            PopStyleVar();
+
+            if (IsItemHovered()) {
+                SetMouseCursor(ImGuiMouseCursor_NotAllowed);
+            }
         } else {
-            if (Button("Uninstall", ImVec2(xPos + GetContentRegionAvail().x, GetContentRegionAvail().y))) {
-                if (isUninstalling) {
-                    return;
-                }
+            float currentColor = EaseInOutFloat("##NextButton", 1.0f, 0.8f, isButtonHovered, 0.3f);
+
+            PushStyleColor(ImGuiCol_Button, ImVec4(currentColor, currentColor, currentColor, 1.0f));
+            PushStyleColor(ImGuiCol_ButtonHovered, ImVec4(currentColor, currentColor, currentColor, 1.0f));
+            PushStyleColor(ImGuiCol_ButtonActive, ImVec4(0.8f, 0.8f, 0.8f, 1.0f));
 
+            if (Button("Uninstall", ImVec2(xPos + GetContentRegionAvail().x, GetContentRegionAvail().y))) {
                 std::cout << "Uninstalling components..." << std::endl;
 
                 isUninstalling = true;
                 std::thread(StartUninstall).detach();
             }
-        }
 
-        if (isButtonHovered) {
-            SetMouseCursor(ImGuiMouseCursor_Hand);
-        }
+            if (isButtonHovered) {
+                SetMouseCursor(ImGuiMouseCursor_Hand);
+            }
 
-        PopStyleColor(3);
-        isButtonHovered = IsItemHovered() || (IsItemHovered(ImGuiHoveredFlags_AllowWhenBlockedByActiveItem) && IsMouseDown(ImGuiMouseButton_Left));
+            PopStyleColor(3);
+            isButtonHovered = IsItemHovered() || (IsItemHovered(ImGuiHoveredFlags_AllowWhenBlockedByActiveItem) && IsMouseDown(ImGuiMouseButton_Left));
+        }
     });
 }