fix: replace detached threads with BackgroundWorker for safe shutdown

Author: shdwmtr

src/components/titlebar.cc

@@ -33,8 +33,8 @@
 #include <dpi.h>
 #include <components.h>
 #include <animate.h>
-#include <iostream>
 #include <math.h>
+#include <worker.h>
 
 using namespace ImGui;
 
@@ -106,7 +106,8 @@ bool RenderTitleBarComponent(std::shared_ptr<RouterNav> router)
         PopStyleVar();
         EndChild();
 
-        if (IsItemClicked(ImGuiMouseButton_Left)) {
+        if (IsItemClicked(ImGuiMouseButton_Left) && !IsWorkerBusy()) {
+            JoinWorker();
             ExitProcess(0);
         }
 
@@ -120,4 +121,4 @@ bool RenderTitleBarComponent(std::shared_ptr<RouterNav> router)
     PopStyleVar();
 
     return IsItemHovered() || (IsItemHovered(ImGuiHoveredFlags_AllowWhenBlockedByActiveItem) && IsMouseDown(ImGuiMouseButton_Left));
-}
+}

src/include/worker.h

@@ -35,13 +35,12 @@
 #include <memory>
 #include <router.h>
 #include <imgui_internal.h>
-#include <iostream>
 #include <dpi.h>
 #include <unordered_map>
 #include <components.h>
-#include <thread>
 #include <atomic>
 #include <imspinner.h>
+#include <worker.h>
 
 using namespace ImGui;
 using namespace ImSpinner;
@@ -174,7 +173,7 @@ const void RenderHome(std::shared_ptr<RouterNav> router, float xPos)
 
     PushStyleColor(ImGuiCol_Border, ImVec4(0.169f, 0.173f, 0.18f, 1.0f));
 
-    SetCursorPos({ xPos + (viewport->Size.x - ((ContainerWidth * 2) + ContainerSpacing)) / 2, ((viewport->Size.y - BottomNavBarHeight) / 2.0f) - ContainerHeight / 2 });
+    SetCursorPos({ xPos + (viewport->Size.x - ((ContainerWidth * 2) + ContainerSpacing)) / 2, ((viewport->Size.y - BottomNavBarHeight) / 2.0f) - ContainerHeight / 2.0f });
 
     RenderOption({ "Install", "Integrate Millennium into your Steam® Client.", INSTALL }, ContainerWidth, ContainerHeight, ContainerSpacing);
     RenderOption({ "Remove", "Selectively uninstall portions of Millennium.", REMOVE }, ContainerWidth, ContainerHeight, ContainerSpacing);
@@ -242,7 +241,7 @@ const void RenderHome(std::shared_ptr<RouterNav> router, float xPos)
                         isLoading.store(false, std::memory_order_relaxed);
                     };
 
-                    std::thread(StartInstall).detach();
+                    GetWorker().run(StartInstall);
                     break;
                 }
                 case REMOVE:
@@ -257,7 +256,7 @@ const void RenderHome(std::shared_ptr<RouterNav> router, float xPos)
                         isLoading.store(false, std::memory_order_relaxed);
                     };
 
-                    std::thread(StartUninstall).detach();
+                    GetWorker().run(StartUninstall);
                     break;
                 }
                 default:
@@ -314,4 +313,4 @@ const void RenderHome(std::shared_ptr<RouterNav> router, float xPos)
 
     PopStyleVar(2);
     PopStyleColor(4);
-}
+}

src/routes/home.cc

@@ -38,15 +38,14 @@
 #include <router.h>
 #include <iostream>
 #include <dpi.h>
-#include <unordered_map>
 #include <components.h>
-#include <filesystem>
 #include <nlohmann/json.hpp>
 #include <http.h>
 #include <util.h>
 #include <imgui_markdown.h>
 #include <mini/ini.h>
 #include <format>
+#include <worker.h>
 
 using namespace ImGui;
 
@@ -429,7 +428,12 @@ const void RenderInstallPrompt(std::shared_ptr<RouterNav> router, float xPos)
         PushStyleColor(ImGuiCol_ButtonHovered, ImVec4(currentColor, currentColor, currentColor, 1.0f));
 
         if (Button("Install", ImVec2(xPos + GetContentRegionAvail().x, GetContentRegionAvail().y))) {
-            std::thread(StartInstaller, steamPath, std::ref(selectedRelease), std::ref(osReleaseInfo)).detach();
+            auto path = steamPath;
+            auto release = selectedRelease;
+            auto osRelease = osReleaseInfo;
+            GetWorker().run([path, release, osRelease]() {
+                StartInstaller(path, release, osRelease);
+            });
             router->navigateNext();
         }
 

src/routes/install_prompt.cc

@@ -38,13 +38,11 @@
 #include <router.h>
 #include <iostream>
 #include <dpi.h>
-#include <unordered_map>
 #include <components.h>
-#include <map>
 #include <filesystem>
 #include <imspinner.h>
 #include <util.h>
-#include <thread>
+#include <worker.h>
 
 using namespace ImGui;
 using namespace ImSpinner;
@@ -421,7 +419,7 @@ const void RenderUninstallSelect(std::shared_ptr<RouterNav> router, float xPos)
                 std::cout << "Uninstalling components..." << std::endl;
 
                 isUninstalling = true;
-                std::thread(StartUninstall).detach();
+                GetWorker().run(StartUninstall);
             }
 
             if (isButtonHovered) {
@@ -432,4 +430,4 @@ const void RenderUninstallSelect(std::shared_ptr<RouterNav> router, float xPos)
             isButtonHovered = IsItemHovered() || (IsItemHovered(ImGuiHoveredFlags_AllowWhenBlockedByActiveItem) && IsMouseDown(ImGuiMouseButton_Left));
         }
     });
-}
+}

src/routes/uninstall_select.cc

@@ -0,0 +1,37 @@
+/**
+ * ==================================================
+ *   _____ _ _ _             _
+ *  |     |_| | |___ ___ ___|_|_ _ _____
+ *  | | | | | | | -_|   |   | | | |     |
+ *  |_|_|_|_|_|_|___|_|_|_|_|_|___|_|_|_|
+ *
+ * ==================================================
+ *
+ * Copyright (c) 2025 Project Millennium
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+#include <worker.h>
+
+static BackgroundWorker g_worker;
+
+BackgroundWorker& GetWorker() { return g_worker; }
+bool IsWorkerBusy() { return g_worker.busy(); }
+void JoinWorker() { g_worker.join(); }