Patch support for clang till cpp20.#688
Patch support for clang till cpp20.#688ninetailedtori wants to merge 9 commits intoSteamClientHomebrew:nextfrom
Conversation
Signed-off-by: Toria <ninetailedtori@uwu.gal>
Signed-off-by: Toria <ninetailedtori@uwu.gal>
8823d1e to
15ba94a
Compare
ec2e44c to
50a4b42
Compare
|
oh whoops I had a local commit I forgot to push. the "missing" functions are in |
|
noice :3 I'm gonna remove my makeshift ones then! |
Signed-off-by: Toria <ninetailedtori@uwu.gal>
Signed-off-by: Toria <ninetailedtori@uwu.gal>
There was a problem hiding this comment.
Thanks for the PR! One small thing before merging:
has_loaded_core_plugin: this field is initialized to false in the constructor but never read or written to again. It can be removed entirely rather than marked [[maybe_unused]].
Everything else looks good, the linux_legacy.cc cleanup is clean.
Smashed that fix, ready to merge! |
No description provided.