Skip to content

Patch support for clang till cpp20.#688

Open
ninetailedtori wants to merge 9 commits intoSteamClientHomebrew:nextfrom
ninetailedtori:log-fix-next
Open

Patch support for clang till cpp20.#688
ninetailedtori wants to merge 9 commits intoSteamClientHomebrew:nextfrom
ninetailedtori:log-fix-next

Conversation

@ninetailedtori
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Toria <ninetailedtori@uwu.gal>
Signed-off-by: Toria <ninetailedtori@uwu.gal>
@shdwmtr
Copy link
Copy Markdown
Member

shdwmtr commented Mar 21, 2026

oh whoops I had a local commit I forgot to push. the "missing" functions are in next now

@ninetailedtori
Copy link
Copy Markdown
Contributor Author

ninetailedtori commented Mar 21, 2026

noice :3 I'm gonna remove my makeshift ones then!

Signed-off-by: Toria <ninetailedtori@uwu.gal>
Signed-off-by: Toria <ninetailedtori@uwu.gal>
Copy link
Copy Markdown
Member

@shdwmtr shdwmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One small thing before merging:

has_loaded_core_plugin: this field is initialized to false in the constructor but never read or written to again. It can be removed entirely rather than marked [[maybe_unused]].

Everything else looks good, the linux_legacy.cc cleanup is clean.

@ninetailedtori
Copy link
Copy Markdown
Contributor Author

Thanks for the PR! One small thing before merging:

has_loaded_core_plugin: this field is initialized to false in the constructor but never read or written to again. It can be removed entirely rather than marked [[maybe_unused]].

Everything else looks good, the linux_legacy.cc cleanup is clean.

Smashed that fix, ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants