fix: Fix plugins generated from the plugin template having the same plugin ID

Author: shdwmtr

.github/workflows/ci.yml

@@ -63,14 +63,22 @@ jobs:
 
           echo "submodule-matrix=$(cat submodules.json)" >> $GITHUB_OUTPUT
 
+      - name: Update README stats
+        run: |
+          STAT_OUTPUT=$(bash ./scripts/_stat.sh)
+
+          # Replace everything from "## Repository Manifest" to end of file
+          BEFORE=$(sed '/^## Repository Manifest$/,$d' README.md)
+          printf '%s\n%s\n' "$BEFORE" "$STAT_OUTPUT" > README.md
+
       - name: Commit Metadata
         if: github.event_name != 'pull_request' && github.event.repository.fork == false
         run: |
           git config --global user.name 'github-actions[bot]'
           git config --global user.email 'github-actions[bot]@users.noreply.github.com'
 
           # Stage the changes
-          git add metadata.json
+          git add metadata.json README.md
 
           # Commit only if there are changes
           if git commit -m "chore: Add plugin metadata"; then

scripts/_gen_metadata.sh

@@ -1,12 +1,22 @@
 #!/bin/bash
 
 parse_plugin() {
+    # Abstract:
+    # plugin_name = unique hash in the git repository that will not change unless the history is force deleted.
+    # commit_id = latest commit from the repository
+    #
+    # We need to use an ID for a plugin name because we have no other static information that will *always*
+    # identify a repository. Ex: using actual owner/repo if the user changed their name or repo name it would break millennium.
+
     local plugins_dir=$1
     local submodule=$2
     local submodule_path="$plugins_dir/$submodule"
     local plugin_name commit_id
-    
-    plugin_name=$(git -C "$submodule_path" rev-list --max-parents=0 HEAD 2>/dev/null | tr -d '\n')
+
+    # Get the first commit that isn't from me (i.e if they used the plugin template)
+    plugin_name=$(git -C "$submodule_path" log --format='%H %ae' --reverse 2>/dev/null | grep -Fv '81448108+shdwmtr@users.noreply.github.com' | head -1 | cut -d' ' -f1 | tr -d '\n')
+    # Fallback to root commit if all commits are ours
+    [[ -z "$plugin_name" ]] && plugin_name=$(git -C "$submodule_path" rev-list --max-parents=0 HEAD 2>/dev/null | tr -d '\n')
     commit_id=$(git -C "$submodule_path" rev-parse HEAD 2>/dev/null | tr -d '\n')
 
     echo "{\"id\": \"$plugin_name\", \"commitId\": \"$commit_id\"}"

scripts/_stat.sh

@@ -0,0 +1,72 @@
+#!/bin/bash
+
+PYTHON_PLUGINS=()
+LUA_PLUGINS=()
+
+while IFS= read -r line; do
+    submodule_path=$(echo "$line" | awk '{print $2}')
+
+    if [[ -z "$submodule_path" ]]; then
+        continue
+    fi
+
+    plugin_json="$submodule_path/plugin.json"
+    plugin_name=$(basename "$submodule_path")
+
+    if [[ -f "$plugin_json" ]]; then
+        backend_type=$(jq -r '.backendType // "undefined"' "$plugin_json" 2>/dev/null)
+        use_backend=$(jq -r 'if has("useBackend") then .useBackend else true end' "$plugin_json" 2>/dev/null)
+
+        if [[ "$use_backend" == "false" || "$backend_type" == "lua" ]]; then
+            LUA_PLUGINS+=("$plugin_name")
+        else
+            PYTHON_PLUGINS+=("$plugin_name")
+        fi
+    else
+        echo "Warning: No plugin.json found in $submodule_path"
+    fi
+done < <(git submodule status)
+
+TOTAL_PLUGINS=$(( ${#LUA_PLUGINS[@]} + ${#PYTHON_PLUGINS[@]} ))
+
+echo "## Repository Manifest"
+echo ""
+
+# Determine the max rows needed
+max_rows=${#LUA_PLUGINS[@]}
+if (( ${#PYTHON_PLUGINS[@]} > max_rows )); then
+    max_rows=${#PYTHON_PLUGINS[@]}
+fi
+
+echo "The following table describes the remaining deprecated Python plugins that need to be ported to Lua."
+echo "Python is no longer officially supported by Millennium and will be removed entirely in a future update."
+
+echo ""
+echo "**Total**: ${TOTAL_PLUGINS}"
+echo " * **Lua**: ${#LUA_PLUGINS[@]}"
+echo " * **Python**: ${#PYTHON_PLUGINS[@]}"
+echo ""
+echo ""
+
+echo "| Lua | Python |"
+echo "|-----|--------|"
+
+for (( i=0; i<max_rows; i++ )); do
+    if (( i < ${#LUA_PLUGINS[@]} )); then
+        lua_num="$(( i + 1 ))"
+        lua_name="${LUA_PLUGINS[$i]}"
+    else
+        lua_num=""
+        lua_name=""
+    fi
+
+    if (( i < ${#PYTHON_PLUGINS[@]} )); then
+        py_num="$(( i + 1 ))"
+        py_name="${PYTHON_PLUGINS[$i]}"
+    else
+        py_num=""
+        py_name=""
+    fi
+
+    echo "| $lua_name | $py_name |"
+done