Skip to content

Commit c27bd8a

Browse files
committed
Consul: don't use UseNetworkInterfaces to determine ports (reverts change from #1666)
1 parent 00a68c7 commit c27bd8a

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

src/Discovery/src/Consul/Configuration/ConsulDiscoveryOptions.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,7 @@ public sealed class ConsulDiscoveryOptions
176176
/// <summary>
177177
/// Gets or sets a value indicating whether to register with the port number ASP.NET Core is listening on. Default value: true.
178178
/// <para />
179-
/// This property is ignored when <see cref="Port" /> or <see cref="Scheme" /> is explicitly configured, or when <see cref="UseNetworkInterfaces" /> is
180-
/// <c>true</c>.
179+
/// This property is ignored when <see cref="Port" /> or <see cref="Scheme" /> is explicitly configured.
181180
/// </summary>
182181
public bool UseAspNetCoreUrls { get; set; } = true;
183182
}

src/Discovery/src/Consul/ConfigurationSchema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
},
189189
"UseAspNetCoreUrls": {
190190
"type": "boolean",
191-
"description": "Gets or sets a value indicating whether to register with the port number ASP.NET Core is listening on. Default value: true.\n\nThis property is ignored when 'Steeltoe.Discovery.Consul.Configuration.ConsulDiscoveryOptions.Port' or 'Steeltoe.Discovery.Consul.Configuration.ConsulDiscoveryOptions.Scheme' is explicitly configured, or when 'Steeltoe.Discovery.Consul.Configuration.ConsulDiscoveryOptions.UseNetworkInterfaces' is true."
191+
"description": "Gets or sets a value indicating whether to register with the port number ASP.NET Core is listening on. Default value: true.\n\nThis property is ignored when 'Steeltoe.Discovery.Consul.Configuration.ConsulDiscoveryOptions.Port' or 'Steeltoe.Discovery.Consul.Configuration.ConsulDiscoveryOptions.Scheme' is explicitly configured."
192192
},
193193
"UseNetworkInterfaces": {
194194
"type": "boolean",

src/Discovery/src/Consul/PostConfigureConsulDiscoveryOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public void PostConfigure(string? name, ConsulDiscoveryOptions options)
6262
options.HostName = options.IPAddress;
6363
}
6464

65-
if (options is { UseAspNetCoreUrls: true, Port: 0, Scheme: null, UseNetworkInterfaces: false })
65+
if (options is { UseAspNetCoreUrls: true, Port: 0, Scheme: null })
6666
{
6767
ICollection<string> addresses = _configuration.GetListenAddresses();
6868
SetSchemeWithPortFromListenAddresses(options, addresses);

0 commit comments

Comments
 (0)