fix: Prevent infinite recursion in widget close handlers

- Add isClosing flag to prevent re-entry in handleClose()
- Add isClosing flag to ChatInterface.close() to prevent callback recursion
- Properly disconnect LiveKit client before closing chat interface
- Fixes 'Maximum call stack size exceeded' error when closing widget

Author: StephaneWamba

widget/src/ui/chat-interface.ts

@@ -34,6 +34,7 @@ export class ChatInterface {
   private emojiPicker: HTMLDivElement | null = null
   private emojiButton: HTMLButtonElement | null = null
   private isEmojiPickerOpen = false
+  private isClosing = false // Prevent infinite recursion in close callback
 
   constructor(config: ChatInterfaceConfig) {
     this.config = config
@@ -1359,16 +1360,30 @@ export class ChatInterface {
    * Close chat window
    */
   close(): void {
-    if (this.window) {
-      this.window.style.display = 'none'
-      this.isOpen = false
+    // Prevent infinite recursion
+    if (this.isClosing) {
+      return
     }
-    // Close emoji picker if open
-    this.closeEmojiPicker()
-    // Stop audio monitoring when closing
-    this.stopAudioMonitoring()
-    if (this.config.onClose) {
-      this.config.onClose()
+    this.isClosing = true
+
+    try {
+      if (this.window) {
+        this.window.style.display = 'none'
+        this.isOpen = false
+      }
+      // Close emoji picker if open
+      this.closeEmojiPicker()
+      // Stop audio monitoring when closing
+      this.stopAudioMonitoring()
+      // Call callback (the widget's handleClose has its own guard to prevent recursion)
+      if (this.config.onClose) {
+        this.config.onClose()
+      }
+    } finally {
+      // Reset flag after a short delay to allow cleanup
+      setTimeout(() => {
+        this.isClosing = false
+      }, 100)
     }
   }
 

widget/src/widget.ts

@@ -22,6 +22,7 @@ export class SynteraWidget {
   private isInitialized = false
   private consentData: ConsentData | null = null
   private gdprModal: GDPRConsentModal | null = null
+  private isClosing = false // Prevent infinite recursion in close handlers
 
   constructor(config: WidgetConfig) {
     this.config = config
@@ -377,15 +378,36 @@ export class SynteraWidget {
    * Handle closing the widget
    */
   private handleClose(): void {
-    // Disconnect WebSocket
-    if (this.wsClient) {
-      this.wsClient.disconnect()
-      this.wsClient = null
+    // Prevent infinite recursion
+    if (this.isClosing) {
+      return
     }
+    this.isClosing = true
 
-    // Close chat interface
-    if (this.chatInterface) {
-      this.chatInterface.close()
+    try {
+      // Disconnect LiveKit client first
+      if (this.liveKitClient) {
+        this.liveKitClient.disconnect().catch((error) => {
+          logger.error('Error disconnecting LiveKit client:', error)
+        })
+        this.liveKitClient = null
+      }
+
+      // Disconnect WebSocket
+      if (this.wsClient) {
+        this.wsClient.disconnect()
+        this.wsClient = null
+      }
+
+      // Close chat interface (this will trigger onClose callback, but we're protected by isClosing flag)
+      if (this.chatInterface) {
+        this.chatInterface.close()
+      }
+    } finally {
+      // Reset flag after a short delay to allow cleanup
+      setTimeout(() => {
+        this.isClosing = false
+      }, 100)
     }
   }