Remove shared preferences banners

Author: rostikjoystick

app/src/main/java/org/stepic/droid/preferences/SharedPreferenceHelper.java

@@ -112,8 +112,6 @@ public class SharedPreferenceHelper {
     private final static String IS_PERSONALIZED_ONBOARDING_WAS_SHOWN = "is_personalized_onboarding_was_shown";
     private final static String ENDPOINT_CONFIG = "endpoint_config";
 
-    private final static String BANNERS_JSON = "banners_json";
-
     private OAuthResponse cachedAuthStepikResponse = null;
 
 
@@ -874,14 +872,6 @@ public int getEndpointConfig() {
         return getInt(PreferenceType.DEVICE_SPECIFIC, ENDPOINT_CONFIG, 2);
     }
 
-    public void putBannersJson(String json) {
-        put(PreferenceType.DEVICE_SPECIFIC, BANNERS_JSON, json);
-    }
-
-    public String getBannersJson() {
-        return getString(PreferenceType.DEVICE_SPECIFIC, BANNERS_JSON);
-    }
-
     @Nullable
     public String getCookiesHeader() {
         return getString(PreferenceType.LOGIN, COOKIES_HEADER);

app/src/main/java/org/stepik/android/domain/banner/interactor/BannerInteractor.kt

@@ -4,6 +4,7 @@ import com.google.firebase.remoteconfig.FirebaseRemoteConfig
 import com.google.gson.Gson
 import com.google.gson.reflect.TypeToken
 import io.reactivex.Single
+import org.stepic.droid.configuration.RemoteConfig
 import org.stepic.droid.preferences.SharedPreferenceHelper
 import org.stepik.android.domain.banner.model.Banner
 import java.lang.Exception
@@ -18,10 +19,8 @@ constructor(
 ) {
     fun getBanners(screen: Banner.Screen): Single<List<Banner>> =
         Single.fromCallable {
-            val bannersJson: String? = sharedPreferenceHelper.bannersJson
-//            val bannersJson = firebaseRemoteConfig.getString(RemoteConfig.BANNERS_ANDROID)
-            if (bannersJson == null || bannersJson.isEmpty()) {
-                sharedPreferenceHelper.putBannersJson("")
+            val bannersJson = firebaseRemoteConfig.getString(RemoteConfig.BANNERS_ANDROID)
+            if (bannersJson.isEmpty()) {
                 emptyList()
             } else {
                 try {