Skip to content

APPS-3856 Hide Facebook and Instagram items from About screen #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
XanderZhu wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

APPS-3856 Hide Facebook and Instagram items from About screen #993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/src/main/java/org/stepic/droid/social/SocialMedia.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,5 @@ enum class SocialMedia(
@DrawableRes
val drawable: Int
) {
VK("https://vk.com/rustepik", R.drawable.ic_login_social_vk),
FACEBOOK("https://www.facebook.com/rustepik/", R.drawable.ic_login_social_fb),
INSTAGRAM("https://www.instagram.com/stepik.education/", R.drawable.ic_social_instagram)
VK("https://vk.com/rustepik", R.drawable.ic_login_social_vk)
}
5 changes: 3 additions & 2 deletions app/src/main/java/org/stepic/droid/ui/fragments/AboutAppFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.fragment.app.Fragment
import androidx.recyclerview.widget.GridLayoutManager
import androidx.recyclerview.widget.LinearLayoutManager
import dev.androidbroadcast.vbpd.viewBinding
import org.stepic.droid.BuildConfig
import org.stepic.droid.R
Expand Down Expand Up @@ -50,7 +50,8 @@ class AboutAppFragment : FragmentBase() {
}

private fun initSocialRecycler() {
aboutAppBinding.socialListRecyclerView.layoutManager = GridLayoutManager(requireContext(), 3)
aboutAppBinding.socialListRecyclerView.layoutManager =
LinearLayoutManager(requireContext(), LinearLayoutManager.HORIZONTAL, false)
aboutAppBinding.socialListRecyclerView.adapter = SocialLinksAdapter(onClick = ::handleSocialClick)
}

Expand Down
9 changes: 0 additions & 9 deletions app/src/main/res/drawable/ic_login_social_fb.xml
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions app/src/main/res/drawable/ic_social_instagram.xml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions app/src/main/res/layout/fragment_about_app.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="wrap_content">
android:orientation="vertical"
android:layout_height="wrap_content"
android:orientation="vertical">

<androidx.appcompat.widget.AppCompatTextView
android:id="@+id/termsOfServiceView"
Expand Down