Merge pull request #51 from StevanFreeborn/stevanfreeborn/fix/50-address-list-values-being-added-to-user-status-field

fix: don't add values to user status field

Author: StevanFreeborn

src/Models/Processor.cs

@@ -441,47 +441,52 @@ List<T> azureObjects
     {
       var field = listFields.FirstOrDefault(f => f.Id == kvp.Key);
 
-      foreach (var azureObject in azureObjects)
+      if (field?.Id == _settings.Onspring.UsersStatusFieldId)
       {
-        if (azureObject is null)
+        continue;
+      }
+
+      foreach (var azureObject in azureObjects)
         {
-          continue;
-        }
+          if (azureObject is null)
+          {
+            continue;
+          }
 
-        var propertyValue = azureObject
-          .GetType()
-          .GetProperty(
-            kvp.Value,
-            BindingFlags.IgnoreCase | BindingFlags.Public | BindingFlags.Instance
-          )
-          ?.GetValue(azureObject);
+          var propertyValue = azureObject
+            .GetType()
+            .GetProperty(
+              kvp.Value,
+              BindingFlags.IgnoreCase | BindingFlags.Public | BindingFlags.Instance
+            )
+            ?.GetValue(azureObject);
 
-        var possibleNewListValues = new List<string?>();
+          var possibleNewListValues = new List<string?>();
 
-        if (propertyValue is null)
-        {
-          continue;
-        }
+          if (propertyValue is null)
+          {
+            continue;
+          }
 
-        if (propertyValue is List<string> propertyValueList)
-        {
-          possibleNewListValues.AddRange(propertyValueList);
-        }
-        else
-        {
-          var propertyValueString = propertyValue.ToString();
+          if (propertyValue is List<string> propertyValueList)
+          {
+            possibleNewListValues.AddRange(propertyValueList);
+          }
+          else
+          {
+            var propertyValueString = propertyValue.ToString();
 
-          possibleNewListValues.Add(propertyValueString);
-        }
+            possibleNewListValues.Add(propertyValueString);
+          }
 
-        foreach (var possibleNewListValue in possibleNewListValues)
-        {
-          if (TryGetNewListValue(field, possibleNewListValue, out var newListValue))
+          foreach (var possibleNewListValue in possibleNewListValues)
           {
-            newListValues.Add(newListValue);
+            if (TryGetNewListValue(field, possibleNewListValue, out var newListValue))
+            {
+              newListValues.Add(newListValue);
+            }
           }
         }
-      }
     }
 
     newListValues = [.. newListValues.DistinctBy(kvp => kvp.Value.ToLower(CultureInfo.InvariantCulture))];
@@ -514,7 +519,6 @@ internal static bool TryGetNewListValue(
     out KeyValuePair<int, string> newListValue
   )
   {
-
     if (
       possibleNewListValue is null ||
       listField is null

tests/UnitTests/ProcessorTests.cs

@@ -2371,6 +2371,108 @@ public void TryGetNewListValue_WhenCalledAndFieldIsNull_ItShouldReturnFalseAndSe
     newListValue.Value.Should().BeNull();
   }
 
+  [Fact]
+  public async Task SyncListValues_WhenCalled_ItShouldAddPropertyValuesToUserStatusFieldList()
+  {
+    var userStatusFieldId = 1;
+
+    var onspringSettings = new OnspringSettings()
+    {
+      UsersStatusFieldId = userStatusFieldId,
+    };
+
+    _settingsMock
+      .SetupGet(static x => x.Onspring)
+      .Returns(onspringSettings);
+
+    _settingsMock
+      .SetupGet(static x => x.Azure)
+      .Returns(new AzureSettings());
+
+    var listFields = new List<ListField>
+    {
+      new()
+      {
+        Id = userStatusFieldId,
+        AppId = 1,
+        Name = "List Field",
+        Type = FieldType.List,
+        Status = FieldStatus.Enabled,
+        IsRequired = true,
+        IsUnique = true,
+        Multiplicity = Multiplicity.MultiSelect,
+        ListId = 1,
+        Values = [
+          new ListValue
+          {
+            Id = Guid.NewGuid(),
+            Name = "Active"
+          }
+        ],
+      },
+    };
+
+    var fieldMappings = new Dictionary<int, string>
+    {
+      { userStatusFieldId, "accountEnabled" },
+    };
+
+    var groups = new List<User?>
+    {
+      new()
+      {
+        Id = "user id",
+        DisplayName = "user Id",
+        AccountEnabled = false,
+      },
+    };
+
+    var updatedListFields = new List<Field>
+    {
+      new ListField()
+      {
+        Id = userStatusFieldId,
+        AppId = 1,
+        Name = "List Field",
+        Type = FieldType.List,
+        Status = FieldStatus.Enabled,
+        IsRequired = true,
+        IsUnique = true,
+        Multiplicity = Multiplicity.MultiSelect,
+        ListId = 1,
+        Values = [
+          new ListValue
+          {
+            Id = Guid.NewGuid(),
+            Name = "group type 1"
+          }
+        ],
+      },
+    };
+
+    _onspringServiceMock
+      .Setup(static x => x.AddListValue(It.IsAny<int>(), It.IsAny<string>()))
+      .ReturnsAsync(new SaveListItemResponse(Guid.NewGuid()));
+
+    _onspringServiceMock
+      .Setup(static x => x.GetGroupFields())
+      .ReturnsAsync(updatedListFields);
+
+    await _processor.SyncListValues(
+      listFields,
+      fieldMappings,
+      groups
+    );
+
+    _onspringServiceMock.Verify(
+      static x => x.AddListValue(
+        It.IsAny<int>(),
+        It.IsAny<string>()
+      ),
+      Times.Never
+    );
+  }
+
   [Fact]
   public async Task SyncListValues_WhenCalledAndNewValuesAreFoundForGroupsListFields_ItShouldAddTheListValuesAndUpdateGroupFields()
   {