Added ignore callback support#144
Open
captainz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Steve,
I am loving knockout so far and find the knock mapping plug-in very useful.
But I missed a generic way to ignore properties to map (currently, you can ignore them by name only).
Hence I decided to add an optional ignore callback to the option - allowing to ignore properties based on patterns (e.g. some naming convention) additionally to the ignore array.
I am using this as a global configuration and all my models (if they follow the naming convention) work with that just fine.
I hope that is a useful addition to have and wanted to contribute this (this is the first time I do such a thing, so apologies for any issues I am causing).
If my approach is not acceptable though, it would be nice to see some similar approach (probably to the other configuration types as well) in the future.
Thanks
Michael