Skip to content

Allow select to work with promise #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmooreitul wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow select to work with promise #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87f7ed4
Allow select to work with promise
Apr 19, 2025
7095071
Update plugin.min.js
Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions mention/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,15 @@
this.editor.focus();
var selection = this.editor.dom.select('span#autocomplete')[0];
this.editor.dom.remove(selection);
this.editor.execCommand('mceInsertContent', false, this.insert(item));

//GET THE INSERT CONTENT
var insertContent = this.insert(item);

//IF THE INSERT CONTENT ISNT A PROMIS INSERTT AS NORMAL
if(!insertContent instanceof Promise) this.editor.execCommand('mceInsertContent', false, insertContent);

//THE INSERT CONTENT IS A PROMISE
else insertContent.then((data) => this.editor.execCommand('mceInsertContent', false, data));
},

insert: function (item) {
Expand Down Expand Up @@ -414,4 +422,4 @@

tinymce.PluginManager.add('mention', tinymce.plugins.Mention);

});
});
2 changes: 1 addition & 1 deletion mention/plugin.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.