Skip to content

Improve curl commands #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rob93c merged 4 commits into from
May 31, 2026
Merged

Improve curl commands #506

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd668a8
Configure retries for curl operations
rob93c May 30, 2026
e73dfad
Simplify curl output
rob93c May 30, 2026
965107f
Add curl parameter to fail on http errors
rob93c May 30, 2026
39e0655
Extract binary download logic into shell function
rob93c May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/actions/setup-ffmpeg/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,23 @@ runs:

elif [[ "${{ runner.os }}" == "macOS" ]]; then
FF_VERSION=$(echo "$FF_VERSION" | awk -F. '{print $1 $2}')
curl -L "https://www.osxexperts.net/ffmpeg${FF_VERSION}arm.zip" -o ffmpeg.zip
curl -sS -L --retry 3 --retry-delay 5 \
"https://www.osxexperts.net/ffmpeg${FF_VERSION}arm.zip" \
-o ffmpeg.zip -w "Downloaded FFmpeg from %{url_effective}\n"
Comment thread
rob93c marked this conversation as resolved.
Outdated
unzip -q ffmpeg.zip
mv ffmpeg "$INSTALL_DIR/ffmpeg"
curl -L "https://www.osxexperts.net/ffprobe${FF_VERSION}arm.zip" -o ffprobe.zip
curl -sS -L --retry 3 --retry-delay 5 \
"https://www.osxexperts.net/ffprobe${FF_VERSION}arm.zip" \
-o ffprobe.zip -w "Downloaded FFprobe from %{url_effective}"
unzip -q ffprobe.zip
mv ffprobe "$INSTALL_DIR/ffprobe"
chmod +x "$INSTALL_DIR/"*
rm -f ffmpeg.zip ffprobe.zip

elif [[ "${{ runner.os }}" == "Windows" ]]; then
curl -L "https://www.gyan.dev/ffmpeg/builds/packages/ffmpeg-$FF_VERSION-essentials_build.zip" -o ffmpeg.zip
curl -sS -L --retry 3 --retry-delay 5 \
"https://www.gyan.dev/ffmpeg/builds/packages/ffmpeg-$FF_VERSION-essentials_build.zip" \
-o ffmpeg.zip -w "Downloaded FFmpeg and FFprobe from %{url_effective}"
unzip -q ffmpeg.zip
find . -type f \( -name ffmpeg.exe -o -name ffprobe.exe \) -exec mv {} "$INSTALL_DIR/" \;
rm -f ffmpeg.zip
Expand Down
Loading