Skip to content

Commit 76f05ec

Browse files
committed
fix: remove unused Microsoft.CodeAnalysis dependencies (#157)
The library emits code via System.Reflection.Emit, not Roslyn, but a global Microsoft.CodeAnalysis.CSharp.Scripting PackageReference in Directory.Build.props pulled Microsoft.CodeAnalysis.CSharp (~6.6MB) and Microsoft.CodeAnalysis.Common into every project, leaking them into consumers' published output. No CodeAnalysis/Roslyn API is used anywhere in the codebase, so remove the references outright rather than masking them with PrivateAssets: - Directory.Build.props: drop global CSharp.Scripting reference - Hyperbee.Expressions: drop CodeAnalysis.Common / CodeAnalysis.CSharp - Hyperbee.Expressions.Lab: drop CodeAnalysis.* plus other unused refs (Hyperbee.Collections, Extensions.Configuration[.Binder]) - Directory.Packages.props: drop orphaned CodeAnalysis version entries Verified: full solution builds (net8/9/10, 0 warnings), all tests pass, and the packed nuspec no longer declares any CodeAnalysis dependency.
1 parent 07bfc76 commit 76f05ec

4 files changed

Lines changed: 0 additions & 12 deletions

File tree

Directory.Build.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<ItemGroup>
88
<PackageReference Include="Nerdbank.GitVersioning" PrivateAssets="all" />
99
<PackageReference Include="Microsoft.SourceLink.GitHub"/>
10-
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" />
1110
</ItemGroup>
1211

1312
<PropertyGroup>

Directory.Packages.props

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@
2424
<PackageVersion Include="MSTest.TestAdapter" Version="4.1.0" />
2525
<PackageVersion Include="MSTest.TestFramework" Version="4.1.0" />
2626
<PackageVersion Include="Microsoft.Extensions.Configuration.Binder" Version="10.0.3" />
27-
<!-- Roslyn: use consistent version for all frameworks -->
28-
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="5.0.0" />
29-
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.0.0" />
30-
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="5.0.0" />
3127
<PackageVersion Include="Hyperbee.Json" Version="3.2.2" />
3228
<PackageVersion Include="Hyperbee.Collections" Version="2.7.3" />
3329
</ItemGroup>

src/Hyperbee.Expressions.Lab/Hyperbee.Expressions.Lab.csproj

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,7 @@
3535
</ItemGroup>
3636

3737
<ItemGroup>
38-
<PackageReference Include="Hyperbee.Collections" />
3938
<PackageReference Include="Hyperbee.Json" />
40-
<PackageReference Include="Microsoft.CodeAnalysis.Common" />
41-
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
42-
<PackageReference Include="Microsoft.Extensions.Configuration" />
43-
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" />
4439
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
4540
<PackageReference Include="Microsoft.Extensions.Http" />
4641
<ProjectReference Include="..\Hyperbee.Expressions\Hyperbee.Expressions.csproj" />

src/Hyperbee.Expressions/Hyperbee.Expressions.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@
3232

3333
<ItemGroup>
3434
<PackageReference Include="Hyperbee.Collections" />
35-
<PackageReference Include="Microsoft.CodeAnalysis.Common" />
36-
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
3735
<PackageReference Include="Microsoft.Extensions.Configuration" />
3836
<PackageReference Include="Microsoft.Extensions.Configuration.Binder" />
3937
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />

0 commit comments

Comments
 (0)