Update create_new_release.yml

Author: varndellwagglebee

.github/workflows/create_new_release.yml

@@ -7,14 +7,6 @@ on:
         description: 'Branch to release from (e.g., main, develop, hotfix/xyz, v1.2)'
         type: string
         required: true
-      is_prerelease:
-        type: boolean
-        required: true
-        default: false
-      is_draft:
-        type: boolean
-        required: true
-        default: false
     secrets:
       GH_TOKEN:
         required: true
@@ -28,24 +20,13 @@ jobs:
   create-release:
     runs-on: ubuntu-latest
     steps:
-      # Fail if trying to cut a prerelease from main
-      - name: Guard no prerelease from main
-        if: ${{ inputs.is_prerelease && inputs.target_branch == 'main' }}
-        run: |
-          echo "❌ Prereleases must not be cut from main. Use develop or hotfix/*."
-          exit 1
-
-      # Fail if trying to cut a stable from develop or hotfix/*
-      - name: Guard stable not from develop/hotfix
-        if: ${{ !inputs.is_prerelease && (startsWith(inputs.target_branch, 'develop') || startsWith(inputs.target_branch, 'hotfix/')) }}
-        run: |
-          echo "❌ Stable releases should come from main or vX.Y servicing branches, not develop/hotfix/*."
-          exit 1
-
       - name: Verify target branch exists on origin
         run: |
-          if ! git ls-remote --exit-code --heads origin "${{ inputs.target_branch }}" >/dev/null; then
-            echo "❌ Branch not found on origin: ${{ inputs.target_branch }}"
+          set -e
+          REPO_URL="https://github.com/${{ github.repository }}.git"
+          BR="${{ inputs.target_branch }}"
+          if ! git ls-remote --exit-code --heads "$REPO_URL" "$BR" >/dev/null; then
+            echo "❌ Branch not found on origin: $BR"
             exit 1
           fi
 
@@ -59,44 +40,40 @@ jobs:
         id: nbgv
         uses: dotnet/nbgv@v0.4.2
         with:
-          toolVersion: 3.8.38-alpha   # keep behavior pinned
-          setAllVars: false
+          toolVersion: 3.8.38-alpha
 
-      - name: Sanity-check - requested prerelease vs computed version
+      - name: Guard - block prerelease from main; block stable from develop/hotfix/*
         run: |
           PRE="${{ steps.nbgv.outputs.PrereleaseVersion }}"
-          if [[ "${{ inputs.is_prerelease }}" == "true" && -z "$PRE" ]]; then
-            echo "❌ Requested prerelease, but NBGV computed a STABLE version."
+          BR="${{ inputs.target_branch }}"
+          if [[ -n "$PRE" && "$BR" == "main" ]]; then
+            echo "❌ Computed PRERELEASE on 'main'. Cut prereleases from develop or hotfix/*."
             exit 1
           fi
-          if [[ "${{ inputs.is_prerelease }}" == "false" && -n "$PRE" ]]; then
-            echo "❌ Requested STABLE, but NBGV computed a PRERELEASE ($PRE)."
+          if [[ -z "$PRE" && ( "$BR" == "develop" || "$BR" =~ ^hotfix/ ) ]]; then
+            echo "❌ Computed STABLE on '$BR'. Stable releases should come from main or vX.Y."
             exit 1
           fi
 
       - name: Tag current commit with NBGV
         run: |
           git config user.name "${{ github.actor }}"
           git config user.email "${{ github.actor }}@users.noreply.github.com"
-          # Creates annotated tag v{NuGetPackageVersion} at HEAD
           nbgv tag || echo "Tag may already exist locally."
           git push origin "v${{ steps.nbgv.outputs.NuGetPackageVersion }}" || echo "Tag already exists on remote."
 
       - name: Create GitHub Release
         env:
           GH_TOKEN: ${{ secrets.GH_TOKEN }}
         run: |
+          TAG="v${{ steps.nbgv.outputs.NuGetPackageVersion }}"
+          PRE="${{ steps.nbgv.outputs.PrereleaseVersion }}"
+          BR="${{ inputs.target_branch }}"
           FLAGS=()
-          [[ "${{ inputs.is_draft }}" == "true"      ]] && FLAGS+=(--draft)
-          [[ "${{ inputs.is_prerelease }}" == "true" ]] && FLAGS+=(--prerelease)
-
-          # Mark latest for stable releases from main or servicing branches vX.Y
-          if [[ "${{ inputs.target_branch }}" == "main" || "${{ inputs.target_branch }}" =~ ^v[0-9]+\.[0-9]+$ ]]; then
-            if [[ "${{ inputs.is_prerelease }}" != "true" ]]; then
-              FLAGS+=(--latest)
-            fi
+          [[ -n "$PRE" ]] || FLAGS+=(--latest)  # latest only for stable
+          # Only mark latest for stable from main or servicing branches vX.Y
+          if [[ -n "$PRE" || ( "$BR" != "main" && ! "$BR" =~ ^v[0-9]+\.[0-9]+$ ) ]]; then
+            FLAGS=("${FLAGS[@]/--latest}")  # strip latest if conditions not met
           fi
-
-          TAG="v${{ steps.nbgv.outputs.NuGetPackageVersion }}"
-          echo "Creating release ${TAG} from '${{ inputs.target_branch }}'"
+          echo "Creating release ${TAG} from '${BR}'"
           gh release create "${TAG}" --title "${TAG}" --generate-notes "${FLAGS[@]}"