Merge pull request #360 from StochasticTree/rfx-cpp-hotfix

Fix assignment bug in RFX category tracker data structure

Author: andrewherren

CHANGELOG.md

@@ -9,6 +9,7 @@
 
 ## Bug Fixes
 
+* Fixed assignment bug in RFX category tracker data structure [#360](https://github.com/StochasticTree/stochtree/pull/360)
 * Fixed several initialization, sampling and prediction bugs for cloglog [#357](https://github.com/StochasticTree/stochtree/pull/357)
 * Fixed num_threads pass-through bug in R BART [#339](https://github.com/StochasticTree/stochtree/pull/339)
 * Fixed probit offset bug in R and Python [#337](https://github.com/StochasticTree/stochtree/pull/337)

NEWS.md

@@ -7,6 +7,7 @@
 
 ## Bug Fixes
 
+* Fixed assignment bug in RFX category tracker data structure [#360](https://github.com/StochasticTree/stochtree/pull/360)
 * Fixed several initialization, sampling and prediction bugs for cloglog [#357](https://github.com/StochasticTree/stochtree/pull/357)
 * Fixed num_threads pass-through bug in R BART [#339](https://github.com/StochasticTree/stochtree/pull/339)
 * Fixed probit offset bug in R and Python [#337](https://github.com/StochasticTree/stochtree/pull/337)

include/stochtree/category_tracker.h

@@ -60,7 +60,7 @@ class SampleCategoryMapper {
 
   inline void SetCategoryId(data_size_t sample_id, int category_id) {
     CHECK_LT(sample_id, num_observations_);
-    observation_indices_[sample_id] = sample_id;
+    observation_indices_[sample_id] = category_id;
   }
 
   inline int NumObservations() {return num_observations_;}