Fix IndexError in mean-only Python BART with categorical covariates#411
Merged
Conversation
The "zero out excluded variable weights" step in BARTModel.sample ran outside the include_*_forest guards, while the weight arrays are only expanded to processed (post-preprocessing, e.g. one-hot) length inside those guards. A mean-only model with categorical covariates therefore indexed an unexpanded variable_weights_variance array with a processed-length boolean mask and raised IndexError. Guard each zero-out with its include_*_forest flag, matching the R implementation in R/bart.R. Adds a regression test (mean-only BART on a categorical DataFrame) and a NEWS entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "zero out excluded variable weights" step in BARTModel.sample ran outside the include_forest guards, while the weight arrays are only expanded to processed (post-preprocessing, e.g. one-hot) length inside those guards. A mean-only model with categorical covariates therefore indexed an unexpanded variable_weights_variance array with a processed-length boolean mask and raised IndexError. Guard each zero-out with its include_forest flag, matching the R implementation in R/bart.R.
Adds a regression test (mean-only BART on a categorical DataFrame) and a NEWS entry.