Fix reproducibility CI: regenerate stale BCF references and fail on drift#414
Merged
Conversation
…rift The cross-platform reproducibility jobs were passing despite mismatches because the check scripts only printed differences and never exited non-zero. Under that blind spot, the four BCF reference CSVs had gone stale: every BCF value (200 y_hat + 100 sigma2) differed from the stored reference in both R and Python, while BART was fine. Current BCF output is in fact cross-platform reproducible (agrees to ~1e-9 across ubuntu/windows/macos, 0 mismatches at the 1e-6 tolerance); the references were simply out of date. Regenerated them from the v0.4.5 release build (origin/main == v0.4.5) in the original CSV format. Also make simple-bart and simple-bcf (R and Python) exit non-zero on any mismatch so future drift turns the CI job red instead of passing silently. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The cross-platform reproducibility jobs were passing despite mismatches. Two issues combined:
printdifferences — they never exit non-zero, so the job stayed green even when results didn't match the references.y_hat+ 100sigma2) differed from the stored reference in both R and Python. (BART was fine.)The current BCF output is in fact cross-platform reproducible — it agrees to ~1e-9 across ubuntu/windows/macos with 0 mismatches at the 1e-6 tolerance. The references were simply out of date, which is why every platform reported the same differences.
Changes
origin/main == v0.4.5), built and run in both R and Python, in the original CSV format (headers, precision, line counts unchanged).simple-bart/simple-bcf(R and Python) now exit non-zero on any mismatch, so future drift turns the CI job red instead of passing silently.Verification
🤖 Generated with Claude Code