Thumb Icons For Voting, Linking Author Steam Profile In Workshop Flyout, Dealing With HL2 Mounting#197
Draft
OrsellGit wants to merge 6 commits into
Draft
Thumb Icons For Voting, Linking Author Steam Profile In Workshop Flyout, Dealing With HL2 Mounting#197OrsellGit wants to merge 6 commits into
OrsellGit wants to merge 6 commits into
Conversation
Closed
Contributor
Author
|
So originally this wasn't the case when I started this, but now episodes are only recognized under HL2's AppID 220, even when HL2 isn't mounted. This throws a wrench into what I did and didn't catch this before because I was working with the original behavior when they were still separate. Now, the current behavior, even when episodes are mounted, the panorama will not recognize them as mounted. I will need to undo what I did or wait until internal behavior allows for a proper check. |
… sound for missing deps
…thout some enforcement
…sitioning is still WIP
dc76bb4 to
eae81fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, this branch was just for implementing the thumb icons I made to replace the old P2 low-quality icons or temporary text with higher-quality SVGs. These are semi-temporary as most if not all the icons we use need to be gone through and redesigned to fit the P2:CE style more.
In this branch, I also added the ability to view a workshop author's Steam profile by clicking their icon. Current position for this is also temporary, as some items in there, like the author name and maybe the addon description, need to be added.
I also took the liberty of fixing an issue with mounting with HL2 where because the episodes AppIDs are still considered not HL2's AppID (220) in the mount.kv file, so the check for HL2 and episodes doesn't properly work as it currently only checks for HL2's AppID. This is a temporary fix in case this needs to be pushed publicly before anything with the mounts.kv is fixed to accommodate this issue. P1 should also ideally be bundled with this problem since it uses the same statement and check function.