Skip to content

remove tonemapping, color correction, and bloom settings#203

Merged
iamsirenstorm merged 1 commit into
StrataSource:mainfrom
lenship2:main
Jun 6, 2026
Merged

remove tonemapping, color correction, and bloom settings#203
iamsirenstorm merged 1 commit into
StrataSource:mainfrom
lenship2:main

Conversation

@lenship2

@lenship2 lenship2 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

We're going back in StrataSource to the p2ce-panorama-ui to get tonemapping OFF. THE. MENU.

i'm not entirely sure if this would need internal code changes as well, this is my first time doing panorama stuff.

the reasoning behind this is that disabling tonemapping, color correction, and bloom only serves to hinder a maps intended visuals, and doesn't affect performance in any notable way. two immediate examples of campaigns drastically affected by the removal of tonemapping/colorcorrection are the Portal 2 campaign, which uses high autoexposure values in combination with dark lighting, and the HL2 Episodes, which make heavy use of tonemapping for realistic outdoor lighting and color correction for scripted sequences.

i'm not entirely sure if this would need internal code changes as well, this is my first time doing panorama stuff

for a visual example, here's sp_a2_triple_laser with the tonemapping setting enabled vs disabled
image
image

…apping OFF THE MENU.

That's right, we're going back in StrataSource to the p2ce-panorama-ui to get tonemapping OFF. THE. MENU.

the reasoning is that disabling tonemapping, color correction, and bloom only serves to hinder a maps intended visuals, and doesn't affect performance in any notable way. two immediate examples of campaigns drastically affected by the removal of tonemapping/colorcorrection are the Portal 2 campaign, which uses high autoexposure values in combination with dark lighting, and the HL2 Episodes, which make heavy use of tonemapping for realistic outdoor lighting and color correction for scripted sequences.
@lenship2 lenship2 requested a review from a team as a code owner June 6, 2026 02:21
@iamsirenstorm

Copy link
Copy Markdown
Member

Seems reasonable for Tonemapping and Color Correction, but are we sure we want to get rid of Bloom? I'm not sure how drastic Bloom is in Source specifically, and what the effects would be if someone were to turn it off.

@lenship2

lenship2 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

bloom is controlled by tonemapping, and in most cases isn't really noticeable when it's disabled (outside of maps that use it to define the visuals in the first place)

@iamsirenstorm

Copy link
Copy Markdown
Member

Ah, okay. Then we can get rid of all 3 from the menu. Thanks!

@iamsirenstorm iamsirenstorm merged commit 4c29f85 into StrataSource:main Jun 6, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants