porting to cmsdk v2.0

Author: tyler-gilbert

CHANGES.md

@@ -7,6 +7,10 @@
 - Updated CMake files to use CMakeSDK v2.0 or greater
 - Add `magic_enum` to `VarAPI` to convert `enum class` to/from string and to iterate all values
 
+## Bug Fixes
+
+- Remove unused member from `fs::Path`
+- Make `fs::Path` a `static` only class (cannot be constructed)
 
 # Version 1.4.0
 

libraries/FsAPI/include/fs/Path.hpp

@@ -31,6 +31,7 @@ namespace fs {
  */
 
 class Path {
+  Path() = default;
 public:
   API_NO_DISCARD static var::StringView suffix(var::StringView path);
   API_NO_DISCARD static var::StringView name(var::StringView path);
@@ -49,9 +50,6 @@ class Path {
    *
    */
   API_NO_DISCARD static bool is_hidden(var::StringView path);
-
-private:
-  var::StringView m_path;
 };
 } // namespace fs
 

libraries/VarAPI/include/var/MagicEnum.hpp

@@ -12,9 +12,9 @@
 namespace var {
 
 template <class Type> class MagicEnum {
-public:
   MagicEnum() = default;
 
+public:
   static StringView to_string_view(Type value) {
     return StringView{magic_enum::enum_name(value)};
   }
@@ -24,17 +24,12 @@ template <class Type> class MagicEnum {
   }
 
   static auto from_string_view(var::StringView name) {
-    return magic_enum::enum_cast<Type>(std::string{name.to_std_string_view()});
+    return magic_enum::enum_cast<Type>(name.to_std_string_view());
   }
 
-  static size_t count(){
-    return magic_enum::enum_count<Type>();
-  }
-
-  static constexpr auto list(){
-    return magic_enum::enum_values<Type>();
-  }
+  static size_t count() { return magic_enum::enum_count<Type>(); }
 
+  static constexpr auto list() { return magic_enum::enum_values<Type>(); }
 
 private:
 };

tests/VarAPI/src/UnitTest.hpp

@@ -142,8 +142,16 @@ class UnitTest : public test::Test {
     TEST_ASSERT(MagicX::from_cstring("x5").value() == X::x5);
     TEST_ASSERT(!MagicX::from_cstring("x6").has_value());
 
+    TEST_ASSERT(MagicX::from_string_view("x0").value() == X::x0);
+    TEST_ASSERT(MagicX::from_string_view("x1").value() == X::x1);
+    TEST_ASSERT(MagicX::from_string_view("x2").value() == X::x2);
+    TEST_ASSERT(MagicX::from_string_view("x3").value() == X::x3);
+    TEST_ASSERT(MagicX::from_string_view("x4").value() == X::x4);
+    TEST_ASSERT(MagicX::from_string_view("x5").value() == X::x5);
+    TEST_ASSERT(!MagicX::from_string_view("x6").has_value());
+
     int count = 0;
-    for (const auto &value : MagicX::list()) {
+    for (const auto value : MagicX::list()) {
       const auto sv = MagicX::to_string_view(value);
       printer().key(NumberString(count), sv);
       ++count;