Skip to content

Commit e4784e4

Browse files
Revert try/finally in test_run_interactive_from_environment
Assertion now passes (entrypoint=None added), so cleanup runs normally. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent f6128ce commit e4784e4

1 file changed

Lines changed: 20 additions & 22 deletions

File tree

tests/test_cli.py

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1365,28 +1365,26 @@ def test_run_with_env(self, skipper_runner_run_mock):
13651365
@mock.patch("skipper.runner.run", autospec=True)
13661366
def test_run_interactive_from_environment(self, skipper_runner_run_mock):
13671367
os.environ["SKIPPER_INTERACTIVE"] = "True"
1368-
try:
1369-
command = ["ls", "-l"]
1370-
run_params = command
1371-
self._invoke_cli(global_params=self.global_params, subcmd="run", subcmd_params=run_params)
1372-
expected_fqdn_image = "build-container-image:build-container-tag"
1373-
skipper_runner_run_mock.assert_called_once_with(
1374-
command,
1375-
fqdn_image=expected_fqdn_image,
1376-
environment=[],
1377-
interactive=True,
1378-
name=None,
1379-
net=None,
1380-
publish=(),
1381-
volumes=None,
1382-
entrypoint=None,
1383-
workdir=None,
1384-
workspace=None,
1385-
use_cache=False,
1386-
env_file=(),
1387-
)
1388-
finally:
1389-
del os.environ["SKIPPER_INTERACTIVE"]
1368+
command = ["ls", "-l"]
1369+
run_params = command
1370+
self._invoke_cli(global_params=self.global_params, subcmd="run", subcmd_params=run_params)
1371+
expected_fqdn_image = "build-container-image:build-container-tag"
1372+
skipper_runner_run_mock.assert_called_once_with(
1373+
command,
1374+
fqdn_image=expected_fqdn_image,
1375+
environment=[],
1376+
interactive=True,
1377+
name=None,
1378+
net=None,
1379+
publish=(),
1380+
volumes=None,
1381+
entrypoint=None,
1382+
workdir=None,
1383+
workspace=None,
1384+
use_cache=False,
1385+
env_file=(),
1386+
)
1387+
del os.environ["SKIPPER_INTERACTIVE"]
13901388

13911389
@mock.patch("subprocess.check_output", mock.MagicMock(autospec=True, return_value="1234567\n"))
13921390
@mock.patch("skipper.runner.run", autospec=True)

0 commit comments

Comments
 (0)