Settings: Add discord rich presence#1101
Open
kKaskak wants to merge 4 commits into
Open
Conversation
kKaskak
added
refactor
kKaskak
force-pushed
the
feat/discord-rich-presence
branch
from
17819d6 to
bb356f6
Compare
kKaskak
force-pushed
the
feat/discord-rich-presence
branch
from
bb356f6 to
16e8823
Compare
Botsy
requested changes
May 26, 2026
Member
Botsy
left a comment
Botsy
left a comment
There was a problem hiding this comment.
I tested with suggested fixes and it worked for me. Still I think we might need some improvements in terms of giving feedback to the user when a connection is successful or has failed/is unavailable.
Comment on lines
+63
to
+65
| get available(): boolean { | ||
| return this.shell && this.shell.active; | ||
| } |
Member
There was a problem hiding this comment.
What happens if user doesn't have Discord installed at all? Shouldn't the available flag reflect whether Discord is actually usable (after a successful connection)? And Settings toggle should show and display connection state more clearly (connected / disconnected / unavailable). Probably we need some feedback when connection is successful/failed in toast message as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.