Skip-segment CTA, early next-video trigger, and UX polish#1267
Open
THaenlein wants to merge 2 commits into
Open
Skip-segment CTA, early next-video trigger, and UX polish#1267THaenlein wants to merge 2 commits into
THaenlein wants to merge 2 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shows a floating "Skip {segment}" CTA when playback is inside a validated segment; clicking seeks to the segment end. Triggers the next-video prompt early when entering an outro segment while retaining the existing near-end fallback. Reuses existing i18n key. This PR implements the UI changes for Stremio/stremio-core#979.
Screenshots
Files
Testing
cd stremio-web && pnpm install && pnpm build && pnpm test (lint/i18n)Manually verify in dev server using an episode with IntroDB data:
curl "https://api.introdb.app/segments?imdb_id=tt2356777&season=1&episode=1"(True Detective)curl "https://api.introdb.app/segments?imdb_id=tt0944947&season=1&episode=1"(Game of Thrones)curl "https://api.introdb.app/segments?imdb_id=tt6741278&season=2&episode=2"(Invincible)