fix(Library): filter watched sort results#1293
Open
Cesarsk wants to merge 1 commit into
Open
Conversation
Author
|
I leave here a Security Review, just in case: Security ReviewFindingsNo security issues found in the PR diff. Reviewed Scope
Security Notes
Residual Risk
ConclusionThe change is security-safe for the intended frontend behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear,
I opened this MR as I believe that the Not Watched and Watched options should not be a "sort" option but rather an actual filter. I made a small change that hides the Not Watched items when clicking the filter "Watched". Viceversa, I hid the Watched items in the "Not Watched".
The rationale is that when I want to check what I have not watched yet, I do not want to see items that I have already watched.
similar concept is applied to "Most Watched" items.
Open question
lastwatchedis intentionally unchanged in this PR. Should Last watched also hide not-watched items, or should it continue to show the full library ordered by last watched activity?Summary
Thanks for this amazing project, I hope the contribution is appreciated.
L.