Feat/ Navigation with React Router V6#901
Open
Botsy wants to merge 6 commits into
Open
Conversation
Botsy
requested review from
kKaskak and
tymmesyde
and removed request for
kKaskak
kKaskak
modified the milestones:
v5.0.0-beta.25,
v5.0.0-beta.25[bug fix],
v5.0.0-beta.26,
v5.0.0-beta.26[bug fix],
v5.0.0-beta.27
1 task
Member
|
Played again with this a bit today, blinking issues seems to be gone but i would say it requires more in depth testing by more than one person as this is critical change |
Contributor
|
i cant posibly help for this bug right? |
kKaskak
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
|
@Botsy please resolve conflicts again |
Member
|
@Botsy please resolve conflicts again, sorry |
kKaskak
force-pushed
the
feat/react-router
branch
from
08677f6 to
76185db
Compare
kKaskak
force-pushed
the
feat/react-router
branch
from
76185db to
7a3f331
Compare
Co-Authored-By: botsy <botzy@goodmorning.dev>
Co-Authored-By: botsy <botzy@goodmorning.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to replace the usage of
window.locationandwindow.historyfor navigation and to integrate React Router v6 (version 6 is used or older Node version compatibility >= Node 14)