Skip to content

Commit 520f46f

Browse files
Fix tests
1 parent 268e2d1 commit 520f46f

5 files changed

Lines changed: 109 additions & 93 deletions

File tree

test/.eslintrc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"env": {
3+
"mocha": true
4+
}
5+
}

test/colorize.test.js

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
1-
2-
var expect = require('expect.js')
3-
, colorize = require('../lib/colorize')
1+
var expect = require('expect.js');
2+
var colorize = require('../lib/colorize');
43

54
describe('colorize', function () {
6-
var message = 'hello strider'
5+
var message = 'hello strider';
76
Object.keys(colorize).forEach(function (name) {
87
describe(name, function () {
98
it('should return a string that contains the original message', function () {
10-
expect(colorize[name](message)).to.contain(message)
11-
})
12-
})
13-
})
14-
})
9+
expect(colorize[name](message)).to.contain(message);
10+
});
11+
});
12+
});
13+
});

test/test_job.js

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,32 @@
1-
var expect = require('expect.js')
2-
, EventEmitter = require('events').EventEmitter
3-
, Job = require('../').Job
1+
var expect = require('expect.js');
2+
var EventEmitter = require('events').EventEmitter;
3+
var Job = require('../').Job;
44

55
describe('Job', function () {
6-
var job
6+
var job;
77
describe('with no plugins', function () {
88
beforeEach(function () {
99
job = new Job(
10-
{ id: 'man'
10+
{
11+
id: 'man',
12+
project: {
13+
display_name: 'testing'
14+
}
1115
},
12-
{ fetch: function (dest, userConfig, config, done) {
13-
done(null)
14-
}
15-
}, [], {
16-
io: new EventEmitter()
17-
})
18-
})
16+
{
17+
fetch: function (dest, userConfig, config, done) {
18+
done(null);
19+
}
20+
}, [], {
21+
io: new EventEmitter()
22+
});
23+
});
1924
it('should fail', function (done) {
20-
this.timeout(30)
25+
this.timeout(30);
2126
job.run(function (err) {
22-
expect(err.message).to.match(/plugin/)
23-
done()
24-
})
25-
})
26-
})
27-
})
27+
expect(err.message).to.match(/plugin/);
28+
done();
29+
});
30+
});
31+
});
32+
});

test/test_run.js

Lines changed: 36 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,67 +1,72 @@
1-
var processBuildJob = require('../').process
2-
, EventEmitter = require('events').EventEmitter
1+
var processBuildJob = require('../').process;
2+
var EventEmitter = require('events').EventEmitter;
33

44
describe('Integration', function () {
55
it('should just work', function (done) {
6-
var called =
7-
{ fetch: false
8-
, environment: false
9-
, prepare: false
10-
, test: false
11-
, deploy: false
12-
, cleanup: false
13-
, listen: false
14-
}
6+
var called = {
7+
fetch: false,
8+
environment: false,
9+
prepare: false,
10+
test: false,
11+
deploy: false,
12+
cleanup: false,
13+
listen: false
14+
};
15+
1516
function cachier() {
16-
return cachier
17+
return cachier;
1718
}
19+
1820
processBuildJob({
1921
id: '123',
22+
project: {
23+
display_name: 'testing'
24+
},
2025
type: 'TEST_AND_DEPLOY',
2126
ref: {
2227
branch: 'master'
2328
}
2429
}, { // provider
2530
fetch: function (context, done) {
26-
called.fetch = true
27-
done()
31+
called.fetch = true;
32+
done();
2833
}
2934
}, [{ // jobplugins
3035
listen: function () {
31-
called.listen = true
36+
called.listen = true;
3237
},
3338
environment: function (context, done) {
34-
called.environment = true
35-
done(null, true)
39+
called.environment = true;
40+
done(null, true);
3641
},
3742
prepare: function (context, done) {
38-
called.prepare = true
39-
done(null, true)
43+
called.prepare = true;
44+
done(null, true);
4045
},
4146
test: function (context, done) {
42-
called.test = true
43-
done(null, true)
47+
called.test = true;
48+
done(null, true);
4449
},
4550
deploy: function (context, done) {
46-
called.deploy = true
47-
done(null, true)
51+
called.deploy = true;
52+
done(null, true);
4853
},
4954
cleanup: function (context, done) {
50-
called.cleanup = true
51-
done(null, true)
55+
called.cleanup = true;
56+
done(null, true);
5257
}
5358
}], { // config
5459
dataDir: '/tmp/',
5560
cachier: cachier,
5661
io: new EventEmitter()
5762
}, function (err) {
58-
if (err) return done(err)
63+
if (err) return done(err);
5964
for (var name in called) {
6065
if (!called[name]) {
61-
return done(new Error(name + ' was not called'))
66+
return done(new Error(name + ' was not called'));
6267
}
6368
}
64-
done()
65-
})
66-
})
67-
})
69+
done();
70+
});
71+
});
72+
});

test/utils.test.js

Lines changed: 36 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,63 @@
11

2-
var expect = require('expect.js')
3-
, utils = require('../lib/utils')
2+
var expect = require('expect.js');
3+
var utils = require('../lib/utils');
44

55
describe('utils', function () {
66
describe('exitError', function () {
77
it('should return a subclass of error', function () {
8-
expect(utils.exitError('ls', 27)).to.be.an(Error)
9-
})
8+
expect(utils.exitError('ls', 27)).to.be.an(Error);
9+
});
1010
it('should have a "code" attribute indicating the exit code', function () {
11-
expect(utils.exitError('ls', 27).code).to.equal(27)
12-
})
13-
})
11+
expect(utils.exitError('ls', 27).code).to.equal(27);
12+
});
13+
});
1414

1515
describe('sum', function () {
1616
it('should calculate correctly', function () {
17-
expect(utils.sum([12,3,4])).to.equal(19)
18-
})
19-
})
17+
expect(utils.sum([12,3,4])).to.equal(19);
18+
});
19+
});
2020

2121
describe('runPlugin', function () {
2222
describe('with no action for that phase', function () {
23-
var plugin = {}
23+
var plugin = {};
2424
it('should noop', function (done) {
25-
utils.runPlugin('test', plugin, {}, done)
26-
})
27-
})
25+
utils.runPlugin('test', plugin, {}, done);
26+
});
27+
});
2828
describe('with a string action', function () {
2929
it('should call context.cmd', function (done) {
3030
utils.runPlugin('test', {'test': 'ls'}, {
3131
cmd: function (text) {
32-
expect(text).to.equal('ls')
33-
done()
32+
expect(text).to.equal('ls');
33+
done();
3434
}
35-
}, null)
36-
})
37-
})
35+
}, null);
36+
});
37+
});
3838
describe('with an executable action', function () {
3939
it('should call the action', function (done) {
4040
utils.runPlugin('test', {
41-
test: function () {done()}
42-
}, {}, null)
43-
})
44-
})
45-
})
41+
test: function () {
42+
done();
43+
}
44+
}, {}, null);
45+
});
46+
});
47+
});
4648

4749
describe('normalizeCmd', function () {
4850
it('should process a string', function () {
49-
var cmd = utils.normalizeCmd('ls -l -a')
50-
expect(cmd.command).to.equal('ls')
51-
expect(cmd.args).to.eql(['-l', '-a'])
52-
})
51+
var cmd = utils.normalizeCmd('ls -l -a');
52+
expect(cmd.command).to.equal('ls');
53+
expect(cmd.args).to.eql(['-l', '-a']);
54+
});
5355

5456
it('should process a command and args', function () {
55-
var cmd = utils.normalizeCmd({command: 'ls', args: ['-a']})
56-
expect(cmd.command).to.equal('ls')
57-
expect(cmd.args).to.eql(['-a'])
58-
})
59-
})
60-
})
57+
var cmd = utils.normalizeCmd({command: 'ls', args: ['-a']});
58+
expect(cmd.command).to.equal('ls');
59+
expect(cmd.args).to.eql(['-a']);
60+
});
61+
});
62+
});
6163

0 commit comments

Comments
 (0)