Remove errors from upgrade commands

Ilya Radchenko · Ilya Radchenko · commit d70451dac70e · 2015-02-27T16:27:08.000-05:00
diff --git a/lib/models/upgrade/index.js b/lib/models/upgrade/index.js
@@ -90,24 +90,24 @@ function isNeeded(version, done) {
 
 function isFreshDb(cb) {
   models.User.count(function(err, res) {
-    if (err) throw err;
+    if (err) return cb(err);
 
     if (res === 0) {
       return cb(null, true);
     }
 
-    return cb('there are users.', false);
+    return cb(undefined, false);
   });
 }
 
 function needConfigObj(cb) {
   models.Config.count(function(err, res) {
-    if (err) throw err;
+    if (err) return err;
 
     if (res === 0) {
       return cb(null, true);
     }
 
-    return cb('there are ' + res + 'configs.', false);
+    return cb(undefined, false);
   });
 }

Original file line number	Diff line number	Diff line change
`@@ -90,24 +90,24 @@ function isNeeded(version, done) {`
`90`	`90`
`91`	`91`	`function isFreshDb(cb) {`
`92`	`92`	`models.User.count(function(err, res) {`
`93`		`- if (err) throw err;`
	`93`	`+ if (err) return cb(err);`
`94`	`94`
`95`	`95`	`if (res === 0) {`
`96`	`96`	`return cb(null, true);`
`97`	`97`	`}`
`98`	`98`
`99`		`- return cb('there are users.', false);`
	`99`	`+ return cb(undefined, false);`
`100`	`100`	`});`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`function needConfigObj(cb) {`
`104`	`104`	`models.Config.count(function(err, res) {`
`105`		`- if (err) throw err;`
	`105`	`+ if (err) return err;`
`106`	`106`
`107`	`107`	`if (res === 0) {`
`108`	`108`	`return cb(null, true);`
`109`	`109`	`}`
`110`	`110`
`111`		`- return cb('there are ' + res + 'configs.', false);`
	`111`	`+ return cb(undefined, false);`
`112`	`112`	`});`
`113`	`113`	`}`