Feature: Semantic validation#11
Open
martin-azpillaga wants to merge 10 commits intoStrumenta:masterfrom
Open
Conversation
added 10 commits
June 7, 2023 23:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by issue #1, this PR implements semantic validation for identifiers in the calc language.
Following the rules of most mainstream programming languages, identifiers need to be declared before usage, and cannot be declared multiple times.
In the case of calc, the editor will report errors when:
inputstatements declare the same identifiercalculationexpression has not been declared in previous linesoutputstatement has not been declared in previous linesInstead of an ANTLR listener or visitor, a simple parse tree walker is used to check the relevant nodes.
Additional validation tests have been added to the parsingTest file.
The features of the editor are now documented in the readme.