Remove FFMS2 and BestSource dependencies entirely

Both source filter plugins are no longer used — the pipeline now uses
FFmpeg pipe source exclusively. Integration tests updated to use
BlankClip instead of external source filters, all 12 pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: StuartCameronCode

CLAUDE.md

@@ -842,7 +842,6 @@ The worker sets these via `DependencyLocator`:
 ### Required Plugins (Windows)
 
 All plugins go in `deps/windows-x64/vapoursynth/vs-plugins/`:
-- `ffms2.dll` - Source filter for preview (from [FFMS/ffms2](https://github.com/FFMS/ffms2))
 - `libmvtools.dll` - Motion estimation
 - `EEDI3m.dll` - Edge-directed interpolation
 - `libvs_znedi3.dll` + `nnedi3_weights.bin` - Neural network interpolation
@@ -975,7 +974,6 @@ This runs `xattr -cr` to recursively remove the `com.apple.quarantine` extended
 ### Required Plugins (macOS)
 
 All plugins are native arm64/x64 builds in `deps/macos-{arch}/vapoursynth/plugins/`:
-- `libffms2.dylib` - Source filter for preview (from [FFMS/ffms2](https://github.com/FFMS/ffms2))
 - `libmvtools.dylib` - Motion estimation
 - `libeedi3m.dylib` - Edge-directed interpolation
 - `libznedi3.dylib` + `nnedi3_weights.bin` - Neural network interpolation

README.md

@@ -125,4 +125,4 @@ Stuart Cameron - [stuart-cameron.com](https://stuart-cameron.com)
 
 macOS ARM64 plugins sourced from:
 - **[yuygfgg/Macos_vapoursynth_plugins](https://github.com/yuygfgg/Macos_vapoursynth_plugins)** — pre-built ARM64 VapourSynth plugins for macOS
-- **[FFMS/ffms2](https://github.com/FFMS/ffms2)** — FFMS2 source filter (used for preview)
+- **[Stefan-Olt/vs-plugin-build](https://github.com/Stefan-Olt/vs-plugin-build)** — Cross-platform VapourSynth plugins

Scripts/download-deps-macos.sh

@@ -7,7 +7,7 @@
 # - yuygfgg/Macos_vapoursynth_plugins (https://github.com/yuygfgg/Macos_vapoursynth_plugins)
 #   - neo_f3kdb, dfttest, fftw libraries
 # - Stefan-Olt/vs-plugin-build (https://github.com/Stefan-Olt/vs-plugin-build)
-#   - FFMS2
+#   - pipe_source.py (raw frame reader for VapourSynth)
 #
 # Prerequisites:
 # - Homebrew (for build tools only, not runtime)
@@ -362,38 +362,6 @@ if [ "$ARCH" = "arm64" ]; then
     echo "  Downloaded pre-built ARM64 plugins from yuygfgg"
 fi
 
-# ============================================================================
-# Download FFMS2 (fast source filter — packet-level indexing, no full decode)
-# ============================================================================
-echo ""
-echo "=== Downloading FFMS2 ==="
-
-FFMS2_TAG="ffms2-257712fe8f3f103bfc94d236e8efb02dd18f1bcd"
-FFMS2_URL="https://github.com/Stefan-Olt/vs-plugin-build/releases/download/$FFMS2_TAG/FFmpegSource2-5.0-darwin-aarch64.zip"
-if [ "$ARCH" = "x86_64" ]; then
-    FFMS2_TAG="ffms2-fb5016322ab87a120fcc750c6571e4cf5c9e1a5e"
-    FFMS2_URL="https://github.com/Stefan-Olt/vs-plugin-build/releases/download/$FFMS2_TAG/FFmpegSource2-5.0-darwin-x86_64.zip"
-fi
-
-if [ "$FORCE" = true ] || [ ! -f "$PLUGINS_DIR/libffms2.dylib" ]; then
-    curl -sL "$FFMS2_URL" -o "$BUILD_DIR/ffms2.zip"
-    unzip -q -o "$BUILD_DIR/ffms2.zip" -d "$BUILD_DIR/ffms2"
-
-    # Find and copy the dylib
-    find "$BUILD_DIR/ffms2" -name "*.dylib" -exec cp {} "$PLUGINS_DIR/libffms2.dylib" \;
-
-    # Remove unused X11 dependency (transitive from FFmpeg build, not actually used)
-    install_name_tool -change "/opt/homebrew/opt/libx11/lib/libX11.6.dylib" "/usr/lib/libSystem.B.dylib" "$PLUGINS_DIR/libffms2.dylib" 2>/dev/null || true
-
-    # Fix paths and sign
-    install_name_tool -id "@loader_path/libffms2.dylib" "$PLUGINS_DIR/libffms2.dylib" 2>/dev/null || true
-    codesign -s - -f "$PLUGINS_DIR/libffms2.dylib" 2>/dev/null
-
-    echo "  Downloaded FFMS2"
-else
-    echo "  FFMS2 already exists, skipping"
-fi
-
 # ============================================================================
 # Build plugins from source
 # ============================================================================

Scripts/download-deps-windows.ps1

@@ -7,7 +7,7 @@
     - VapourSynth R73 (portable, includes Python 3.8)
     - Python 3.8 embeddable (for VSScript)
     - FFmpeg (latest GPL build)
-    - VapourSynth plugins (FFMS2, mvtools, nnedi3cl, znedi3, eedi3m, fmtconv, miscfilters, dfttest, neo_f3kdb, cas, fft3dfilter)
+    - VapourSynth plugins (mvtools, nnedi3cl, znedi3, eedi3m, fmtconv, miscfilters, dfttest, neo_f3kdb, cas, fft3dfilter)
     - FFTW library (required by dfttest)
     - Python packages (havsfunc, mvsfunc, adjust)
     - NNEDI3 weights
@@ -197,11 +197,6 @@ $Plugins7z = @(
         Url = "https://github.com/HomeOfVapourSynthEvolution/VapourSynth-EEDI3/releases/download/r8/EEDI3-r8.7z"
         Check = "EEDI3m.dll"
     },
-    @{
-        Name = "FFMS2"
-        Url = "https://github.com/FFMS/ffms2/releases/download/5.0/ffms2-5.0-msvc.7z"
-        Check = "ffms2.dll"
-    },
     @{
         Name = "miscfilters"
         Url = "https://github.com/vapoursynth/vs-miscfilters-obsolete/releases/download/R2/miscfilters-r2.7z"

app/test/vapoursynth_integration_test.dart

@@ -11,7 +11,6 @@ import 'package:path/path.dart' as path;
 void main() {
   late String depsDir;
   late String vspipePath;
-  late String testVideoPath;
 
   setUpAll(() async {
     // Find the deps directory relative to the test file
@@ -46,21 +45,7 @@ void main() {
       }
     }
 
-    vspipePath = Platform.isWindows
-        ? path.join(depsDir, 'vapoursynth', vspipeExe)
-        : path.join(depsDir, 'vapoursynth', vspipeExe);
-
-    // Create a simple test video (Y4M format - raw YUV)
-    testVideoPath = path.join(Directory.systemTemp.path, 'vapourbox_test.y4m');
-    await _createTestVideo(testVideoPath);
-  });
-
-  tearDownAll(() async {
-    // Clean up test video
-    final testFile = File(testVideoPath);
-    if (await testFile.exists()) {
-      await testFile.delete();
-    }
+    vspipePath = path.join(depsDir, 'vapoursynth', vspipeExe);
   });
 
   group('VapourSynth Plugin Loading', () {
@@ -76,7 +61,7 @@ import vapoursynth as vs
 core = vs.core
 
 # List all required plugins (core set that works on both Windows and macOS)
-required = ['std', 'resize', 'bs', 'mv', 'znedi3', 'eedi3m', 'fmtc',
+required = ['std', 'resize', 'mv', 'znedi3', 'eedi3m', 'fmtc',
             'dfttest', 'neo_f3kdb', 'cas', 'dctf', 'deblock', 'rgvs',
             'ctmf', 'warp', 'misc', 'grain', 'tcanny']
 
@@ -97,33 +82,13 @@ else:
     });
   });
 
-  group('FFMS2 Video Loading', () {
-    test('loads video with FFMS2', () async {
-      final script = '''
-import vapoursynth as vs
-core = vs.core
-
-clip = core.ffms2.Source(source=r"$testVideoPath")
-print(f"Loaded: {clip.width}x{clip.height}, {clip.num_frames} frames")
-
-# Output a single frame to verify it works
-clip = clip[0]
-clip.set_output()
-''';
-
-      final result = await _runVspipeScript(vspipePath, script, outputFrames: true);
-      expect(result.exitCode, 0, reason: 'stderr: ${result.stderr}');
-      expect(result.stdout.toString(), contains('Loaded:'));
-    });
-  });
-
   group('Filter Tests', () {
     test('Deband (neo_f3kdb) works', () async {
       final script = '''
 import vapoursynth as vs
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 clip = core.neo_f3kdb.Deband(clip, y=64, cb=64, cr=64)
 print("Deband applied successfully")
 clip = clip[0]
@@ -139,7 +104,7 @@ clip.set_output()
 import vapoursynth as vs
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 clip = core.dfttest.DFTTest(clip, sigma=10.0)
 print("DFTTest applied successfully")
 clip = clip[0]
@@ -155,7 +120,7 @@ clip.set_output()
 import vapoursynth as vs
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 clip = core.cas.CAS(clip, sharpness=0.5)
 print("CAS applied successfully")
 clip = clip[0]
@@ -171,8 +136,7 @@ clip.set_output()
 import vapoursynth as vs
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
-# Simple MVTools test - analyze motion
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 sup = core.mv.Super(clip)
 vectors = core.mv.Analyse(sup, isb=False)
 print("MVTools applied successfully")
@@ -189,8 +153,7 @@ clip.set_output()
 import vapoursynth as vs
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
-# ZNEDI3 for field interpolation
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 clip = core.znedi3.nnedi3(clip, field=1)
 print("ZNEDI3 applied successfully")
 clip = clip[0]
@@ -206,7 +169,7 @@ clip.set_output()
 import vapoursynth as vs
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 clip = core.eedi3m.EEDI3(clip, field=1)
 print("EEDI3 applied successfully")
 clip = clip[0]
@@ -222,7 +185,7 @@ clip.set_output()
 import vapoursynth as vs
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 clip = core.deblock.Deblock(clip, quant=25)
 print("Deblock applied successfully")
 clip = clip[0]
@@ -238,7 +201,7 @@ clip.set_output()
 import vapoursynth as vs
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 clip = core.tcanny.TCanny(clip, sigma=1.5, mode=0)
 print("TCanny applied successfully")
 clip = clip[0]
@@ -272,7 +235,7 @@ import vapoursynth as vs
 import havsfunc as haf
 core = vs.core
 
-clip = core.bs.VideoSource(source=r"$testVideoPath")
+clip = core.std.BlankClip(width=64, height=64, format=vs.YUV420P8, length=10, fpsnum=25, fpsden=1)
 clip = haf.SMDegrain(clip, tr=1, thSAD=300)
 print("SMDegrain applied successfully")
 clip = clip[0]
@@ -285,28 +248,6 @@ clip.set_output()
   });
 }
 
-/// Creates a simple Y4M test video (10 frames of 64x64 gray)
-Future<void> _createTestVideo(String outputPath) async {
-  final file = File(outputPath);
-  final sink = file.openWrite();
-
-  // Y4M header
-  sink.write('YUV4MPEG2 W64 H64 F25:1 Ip A1:1 C420\n');
-
-  // 10 frames of gray
-  for (int frame = 0; frame < 10; frame++) {
-    sink.write('FRAME\n');
-    // Y plane (64x64 = 4096 bytes) - gray value 128
-    sink.add(List.filled(64 * 64, 128));
-    // U plane (32x32 = 1024 bytes) - neutral chroma
-    sink.add(List.filled(32 * 32, 128));
-    // V plane (32x32 = 1024 bytes) - neutral chroma
-    sink.add(List.filled(32 * 32, 128));
-  }
-
-  await sink.close();
-}
-
 /// Runs a VapourSynth script via vspipe
 Future<ProcessResult> _runVspipeScript(
   String vspipePath,

deps/windows-x64/vapoursynth/vs-plugins/ffms2.dll

@@ -177,7 +177,7 @@ VapourBox bundles all runtime dependencies. No external installations are requir
 | VapourSynth | R73 | Video processing framework |
 | FFmpeg | Latest | Video encoding/decoding |
 | havsfunc | Latest | QTGMC implementation |
-| FFMS2 | 5.0 | Source filter for preview |
+| pipe_source.py | - | Raw frame reader for VapourSynth |
 | mvtools | v24 | Motion estimation |
 | znedi3 | Latest | Neural network interpolation |
 | EEDI3m | r8 | Edge-directed interpolation |